Date: Fri, 26 Apr 2024 13:29:19 +0200 From: Emmanuel Vadot <manu@bidouilliste.com> To: Jan Beich <jbeich@FreeBSD.org> Cc: Emmanuel Vadot <manu@FreeBSD.org>, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: ab5f2419c25e - main - x11/xwayland-run: Add new port Message-ID: <20240426132919.808494b0d75821c15f494656@bidouilliste.com> In-Reply-To: <4jbp-1pg3-wny@FreeBSD.org> References: <202311291352.3ATDql0j066996@gitrepo.freebsd.org> <34rc-gieb-wny@FreeBSD.org> <20240424083543.39ab381c632ef32035a0a837@bidouilliste.com> <4jbp-1pg3-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 25 Apr 2024 16:34:20 +0200 Jan Beich <jbeich@FreeBSD.org> wrote: > Emmanuel Vadot <manu@bidouilliste.com> writes: > > > On Tue, 23 Apr 2024 18:20:44 +0200 > > Jan Beich <jbeich@FreeBSD.org> wrote: > > > >> Emmanuel Vadot <manu@FreeBSD.org> writes: > >> > >> > +MAINTAINER= x11@FreeBSD.org > >> > +COMMENT= Run Xwayland and compositor headless > >> > +WWW= https://gitlab.freedesktop.org/ofourdan/xwayland-run > >> > >> Did you dump this on x11@ and run away from updates[1] and bugs[2]? > > > > I "dumped" this on x11@ because I don't really believe in individual > > maintainership. > > Interesting. I have the opposite experience. Either individuals have > free time or transfer maintainership (willingfully or by policy). Teams (like x11@) as composed of individuals. With a team you don't need to transfer maintainership as other/futur members (in theory) will manage the ports or declare it as not handled by the team anymore and either someone will take maintainership or it will be dropped to ports@. > > I didn't addressed the bugs and updates as I have other things more > > important to do. > > At least bug 275430 was filed 3 hours after you've landed the port. > It's a bit strange to run out of free time so quickly and not find > the time again for 5 months. Strange ? I commit something and then go work on the next thing so if a bug appears it's unlikely that I will drop what I'm doing right now to address it (unless it's very critical). For the 5 months it's simply that I forgot about this bug. > I find your port sloppy and upstream project overhyped. Ack on the sloppy part, but if you think it's overhyped why do you care about it so much that you reply to this commit after 5 months ? > xwayland-run (GPLv2) > looks like a reimplementation of Xweston (MIT). While xwayland-run > provides xwfb-run and wlheadless-run useful for CI, those are currently > partially broken in FreeBSD package. CI is the main reason I've added this port. It was for CI at $HOME and $WORK and I haven't had time to work on this again this I commited the ports. > Cage is also not a good choice > for rootful Xwayland with X11 WM/DE due to lack of IPC or Wayland > protocol to turn off screen on idle or similar. > > Do you actually dogfood xwayland-run to justify the statu quo? As said above I added the port because I wanted to use it for my/work CI so I've used it back then, not much since then. > >> Maybe reassign directly to yourself as x11@ has plenty of ports[3] > >> requiring attention. > > > > As said before x11@ is only me (mostly), so : > > > > 1/ That would change a thing > > Focus where help is needed. How important xwayland-run is compared to > other x11@ ports? Is it part of X.org, Mesa, official Wayland distribution > or critical for those? Clearly the port is less important than X.org, Mesa, whatever, which is another reason that I haven't addressed the bug and update. > > 2/ If you have time to waste writing this email you probably have time > > to do some of the updates that x11@ ports needs. > > Fair point. I find bugzilla/phabricator workflow has too much overhead > for lots of trivial changes across many ports. It's OK for complex > changes but those are rare in ports/, except when adding new ports. What I read is : "I want to commit directly without anyone reviewing my changes because I'm too lazy to git arc create" > > 3/ I've invited you again to be x11@ the other day but I guess it's > > easier for you to not work with us (me) and instead complain about us > > (me) > > Downscale, split or allow granular co-maintainership. I can only provide > quality over a limited number of ports e.g., meson for desktop@, icu for > office@, ffmpeg for multimedia@. And there're plenty of my own ports: > > $ rg -lg Makefile\* MAINT.\*jbeich@ | wc -l > 268 > $ rg -lg Makefile\* MAINT.\*x11@ | wc -l > 262 Something like that is planned, more later. -- Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20240426132919.808494b0d75821c15f494656>