From owner-freebsd-current@FreeBSD.ORG Tue Jun 14 20:31:18 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3105C106564A for ; Tue, 14 Jun 2011 20:31:18 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id AAF308FC19 for ; Tue, 14 Jun 2011 20:31:17 +0000 (UTC) Received: by bwz12 with SMTP id 12so6336068bwz.13 for ; Tue, 14 Jun 2011 13:31:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:message-id:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=9llGt/+lV+vcT6nDEulTRxZjiXE8XwQ6D+cfb7ELzO0=; b=Gs92/Kx3ed5/f00mfWlE6FfWZP/bHBkLdZQ2DV8czoIVzZywF3CXZtfHc5qLNjMMEe 3RAreKpe8zGnwwe+Nra4ECGppeF0VE3j6AyIg+LiTULfDw+7QpnVF6K12JZWXGkp+byG jxyKLOlR/4RXD/no36GpZO7LHEyy1AoVODTL8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=cSH6tswWgovwlrS1vs82YaAubnlHyL8V9R7u86TsNlqIbvhzkOWUpoLq39QbfR9qXd Qr452dABBwC/0NgHlC5D3R3zlKv0kgKUijZfnCNZonZf58D/NLXasoo6A2NBRpcCzRRZ d8rVVH1N4N0Fqx6YNTcjg5iBKq7a0N02pSHig= Received: by 10.204.57.135 with SMTP id c7mr5272973bkh.88.1308083476472; Tue, 14 Jun 2011 13:31:16 -0700 (PDT) Received: from mavbook2.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id k10sm5950856bkq.10.2011.06.14.13.31.14 (version=SSLv3 cipher=OTHER); Tue, 14 Jun 2011 13:31:15 -0700 (PDT) Sender: Alexander Motin Message-ID: <4DF7C4D7.9000006@FreeBSD.org> Date: Tue, 14 Jun 2011 23:30:15 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20091212) MIME-Version: 1.0 To: Rick van der Zwet References: <4DF76176.7030207@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: FreeBSD-Current Subject: Re: ATA_PERIODIC_POLL on ATA_I82801HBM_S1 causes lockups X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2011 20:31:18 -0000 Rick van der Zwet wrote: > On 14 June 2011 15:26, Alexander Motin wrote: >> Rick van der Zwet wrote: >>> The ICH8M found in the MacBookPro4,1 has an known issue [1] which >>> locks up when enabling the periodic poll using sidpr (introduced a >>> ``little'' while ago in r214016), making it impossible to boot. >>> >>> Attached patch disables the polling and thus fixes the issue. >>> >>> Br. /Rick >>> [1] http://www.spinics.net/lists/linux-ide/msg23487.html >> Thank you for reminder, but your patch is not exactly right. Could you >> test this one: >> >> Index: ata-intel.c >> =================================================================== >> --- ata-intel.c (revision 223019) >> +++ ata-intel.c (working copy) >> @@ -288,7 +288,9 @@ >> ATA_OUTL(ctlr->r_res2, 0x0C, >> ATA_INL(ctlr->r_res2, 0x0C) | 0xf); >> } >> - } else { >> + /* Skip BAR(5) on ICH8M Apples, system locks up on access. */ >> + } else if (ctlr->chip->chipid != ATA_I82801HBM_S1 || >> + pci_get_subvendor(dev) != 0x106b) { >> ctlr->r_type2 = SYS_RES_IOPORT; >> ctlr->r_rid2 = PCIR_BAR(5); >> ctlr->r_res2 = bus_alloc_resource_any(dev, ctlr->r_type2, > > Works like a charm. Thank you. Committed at r223097. -- Alexander Motin