From owner-svn-src-all@freebsd.org Sun Jul 5 20:05:39 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 052DCA4B3 for ; Sun, 5 Jul 2015 20:05:39 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) by mx1.freebsd.org (Postfix) with SMTP id DAB5F1665 for ; Sun, 5 Jul 2015 20:05:38 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from ilsoft.org (unknown [73.34.117.227]) by outbound2.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Sun, 5 Jul 2015 20:06:07 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t65K5USP030769; Sun, 5 Jul 2015 14:05:30 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1436126730.1191.4.camel@freebsd.org> Subject: Re: svn commit: r285160 - head/sys/conf From: Ian Lepore To: John-Mark Gurney Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Sun, 05 Jul 2015 14:05:30 -0600 In-Reply-To: <20150705194954.GA8523@funkthat.com> References: <201507051415.t65EFxWd044357@repo.freebsd.org> <20150705194954.GA8523@funkthat.com> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.12.10 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Jul 2015 20:05:39 -0000 On Sun, 2015-07-05 at 12:49 -0700, John-Mark Gurney wrote: > Ian Lepore wrote this message on Sun, Jul 05, 2015 at 14:15 +0000: > > Author: ian > > Date: Sun Jul 5 14:15:58 2015 > > New Revision: 285160 > > URL: https://svnweb.freebsd.org/changeset/base/285160 > > > > Log: > > Ensure all the required files get built when you include the IPSEC option. > > Umm.. This looks more like that IPSEC should require that the crypto > device be specified instead of fixing it this way... I considered that, but rejected it given the presence of crypto | ipsec on some of the files already, but not a sufficiency of them to actually build sucessfully. Heavily my thinking that was a personal belief that if you say "option foo" it should just work without you needing to know other (likely not well documented) prerequisite options also need to be set. -- Ian