From owner-svn-src-head@FreeBSD.ORG Mon Jun 15 00:49:44 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1872A106567F; Mon, 15 Jun 2009 00:49:44 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id DFA8E8FC21; Mon, 15 Jun 2009 00:49:43 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id n5F0nggY059249 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 14 Jun 2009 17:49:43 -0700 (PDT) (envelope-from sam@freebsd.org) Message-ID: <4A359AA6.7010101@freebsd.org> Date: Sun, 14 Jun 2009 17:49:42 -0700 From: Sam Leffler Organization: FreeBSD Project User-Agent: Thunderbird 2.0.0.21 (X11/20090411) MIME-Version: 1.0 To: Bruce Evans References: <200906141801.n5EI1Zti056239@svn.freebsd.org> <4A356A0F.3050800@freebsd.org> <20090615075134.K24645@delplex.bde.org> In-Reply-To: <20090615075134.K24645@delplex.bde.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC--Metrics: ebb.errno.com; whitelist Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Ed Schouten Subject: Re: svn commit: r194204 - in head/sys: amd64/conf i386/conf X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2009 00:49:44 -0000 Bruce Evans wrote: > On Sun, 14 Jun 2009, Sam Leffler wrote: > >>> Log: >>> Enable PRINTF_BUFR_SIZE on i386 and amd64 by default. >>> >>> In the past there have been some reports of PRINTF_BUFR_SIZE not >>> functioning correctly. Instead of having garbled console messages, we >>> should just see whether the issues are still there and analyze them. >> >> When I suggested enabling this by default for SMP configurations I was >> reminded it wasn't enabled because of potential stack overflow. > > Stack overflow shouldn't be a problem, since printf shouldn't be called > recursively. You don't need recursion to overflow the stack. I'd love to see someone properly lock printf/console output instead of kludges like PRINTF_BUFR_SIZE. Sam