From owner-p4-projects@FreeBSD.ORG Tue May 25 16:36:29 2010 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id EB1F91065679; Tue, 25 May 2010 16:36:28 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 96D831065675; Tue, 25 May 2010 16:36:28 +0000 (UTC) (envelope-from gpf.kira@gmail.com) Received: from mail-ww0-f54.google.com (mail-ww0-f54.google.com [74.125.82.54]) by mx1.freebsd.org (Postfix) with ESMTP id 05F3A8FC0C; Tue, 25 May 2010 16:36:27 +0000 (UTC) Received: by wwd20 with SMTP id 20so256338wwd.13 for ; Tue, 25 May 2010 09:36:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=2mxVKfZeMODOY9POUaCP6F0SCpbatsToaIhX/caTsfk=; b=J6aJ4sdZF17ZXEQVnB12bQxmqzdSnXmbYYbPc4W4c3SRwegDN9ImU52utCNU4OfHfn AZ/O176FM2xfdYZpBKxHtqVoKNezqLfS/dM2c0kTfHNhlAoH3nE7ajqYwvx5SR2FawSx QJy2NoOi3y1k5R03rwFaB6t745E835lwpBRuQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=d4NyW2z9NZPWtDCu5nO00vW8xpQWpO5RkEl0/CDC86AJFVlItF8LTuv26Y7/XQkE7P 1u98O4z5WduCzPIPSj+jkLX+W0FZI9ZM4ZpUi4bapEQZFLI/nMVYEu8cnSLwHuOw0H7o trMJYpWiEFY52RFR/b12U5L4ABJnc3QV9IwqM= MIME-Version: 1.0 Received: by 10.216.166.68 with SMTP id f46mr4643202wel.6.1274803515444; Tue, 25 May 2010 09:05:15 -0700 (PDT) Received: by 10.216.1.145 with HTTP; Tue, 25 May 2010 09:05:15 -0700 (PDT) In-Reply-To: <201005250858.24659.jhb@freebsd.org> References: <201005241406.o4OE6v5B051548@repoman.freebsd.org> <201005250858.24659.jhb@freebsd.org> Date: Tue, 25 May 2010 19:05:15 +0300 Message-ID: From: Efstratios Karatzas To: John Baldwin Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Perforce Change Reviews , Efstratios Karatzas Subject: Re: PERFORCE change 178714 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 May 2010 16:36:29 -0000 On Tue, May 25, 2010 at 3:58 PM, John Baldwin wrote: > On Monday 24 May 2010 10:06:57 am Efstratios Karatzas wrote: >> http://p4web.freebsd.org/@@178714?ac=3D10 >> >> Change 178714 by gpf@gpf_desktop on 2010/05/24 14:06:34 >> >> =C2=A0 =C2=A0 =C2=A0 * the second parameter from VOP_VPTOCNP() should be= vdrop()ed after >> =C2=A0 =C2=A0 =C2=A0 the call - done >> =C2=A0 =C2=A0 =C2=A0 * dont really need exclusive locks; now I use share= d locks >> =C2=A0 =C2=A0 =C2=A0 * dir_ilookup() still only works for UFS, added a c= heck so that the >> =C2=A0 =C2=A0 =C2=A0 function will return if the fs is not ufs >> >> Affected files ... >> >> .. //depot/projects/soc2010/gpf_audit/vn_fullpath_nocache.c#3 edit >> >> Differences ... >> >> =3D=3D=3D=3D //depot/projects/soc2010/gpf_audit/vn_fullpath_nocache.c#3 = (text+ko) =3D=3D=3D=3D >> >> @@ -75,11 +75,18 @@ >> =C2=A0 =C2=A0 =C2=A0 KASSERT("dvp !=3D NULL", "dir_ilookup: dvp =3D=3D N= ULL"); >> =C2=A0 =C2=A0 =C2=A0 KASSERT("name !=3D NULL", "dir_ilookup: name =3D=3D= NULL"); >> >> + =C2=A0 =C2=A0 /* XXXgpf: temporary, must be a better way to check this= than f_type or f_fstypename */ >> + =C2=A0 =C2=A0 if (strcmp(vp->v_mount->mnt_stat.f_fstypename, "ufs")) { >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 uprintf("only ufs supported\= n"); >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return 1; >> + =C2=A0 =C2=A0 } >> + > > The normal way to handle something like this is by moving the > filesystem-specific functionality into a new VOP. =C2=A0Alternatively, th= e mount > point could grow a new flag (such as MNTK_MPSAFE or MNTK_LOOKUP_SHARED) t= o > indicate that a specific mount supports an optional feature or capability=