From owner-svn-src-all@freebsd.org Sun Nov 18 20:10:39 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 306A2110F060; Sun, 18 Nov 2018 20:10:39 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5BF466DE9C; Sun, 18 Nov 2018 20:10:38 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: by mail-io1-xd35.google.com with SMTP id m19so15117130ioh.3; Sun, 18 Nov 2018 12:10:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p/r+aLHpMxaDAX9cDT4ecBZX66MXZFcRNCPWuTKPtTs=; b=Tvmp64NcMBzJPJIgu1U+CE/6bvvrc4+bEwY5rqky0hFfpVbqY8AFi+/R4qtu6kICsp IPF2pFWCq3gXQpCGm9CXol7+ltzdWOc2qAfilc+KLbPzgg9rgKfTuP9/x5UY0iEjueT4 bOyLyr/sEIEY0cZjFvSgenwTqewFfNc9Vx/dIGKi91kXFXe7uNUb0yBUMbKePdfGunt7 pbGtYbaNYouyjIvqQRe40Ic7Z7xgTPB4llZCgTLU9aAaZ+pEl7ATLkE0sd/Z3/9nY6bt FhKP5/fJibV5zTUcpQ5SCZOwPIFA1QNf2iLAMUWG2+QPhxJKy2mfmi75B70MTTBFfmV8 ZMqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p/r+aLHpMxaDAX9cDT4ecBZX66MXZFcRNCPWuTKPtTs=; b=W9glt2Szb+otueKrO+zcUoXUwztieqhNbrCqN3bZmXUbFCW/xjTYViGfsQge89fdQk XJ/K4Jeoeebl+TrL8qO2ofkdVFpCIVTm4GMkEBp6d72sbJBdcFgSgwnCM1/+P5FyzXZd QoF6oaYwg63zex4cKWACHRRY6aAFgaS+e58JRzEgrT1HqnLr/Zk2a1erGeAeoPrmLcUO 1jEwPaShIMz5btYvVd7jb+1GiJqcLD/QRuPrEtvRUyHjp7f4EBRmz0R0Z2dzZ22dCkgh hUYGeJHHP7SK/jce+pc1ETKnqZPOSLCe2+0G3rpcsNe+Z68JWiKOLGPIm9BoMVFRGl5U DbdA== X-Gm-Message-State: AGRZ1gJ25WbQBjz2h5UmMKClOazWK3yaoxRMBzDOV2GuGhCILi9amdQD 0Nb9nNnE6eQienoQeETEpd1beSmnBCAvUA6M2G2+BMEu X-Google-Smtp-Source: AJdET5e/tZHEetNKIoi220ndM8vE+gsfbnqiwPRbYmrFGQd5D7pe1z//Rbs2bEoEoTTL7lCnE4u50wvfUxQgO2IO8xg= X-Received: by 2002:a6b:8f8d:: with SMTP id r135mr15645182iod.5.1542571836984; Sun, 18 Nov 2018 12:10:36 -0800 (PST) MIME-Version: 1.0 References: <201810222055.w9MKtZPt013627@repo.freebsd.org> <20181118114538.546a4fab@kalimero.tijl.coosemans.org> In-Reply-To: <20181118114538.546a4fab@kalimero.tijl.coosemans.org> From: Matthew Macy Date: Sun, 18 Nov 2018 12:10:25 -0800 Message-ID: Subject: Re: svn commit: r339618 - head/sys/compat/linuxkpi/common/include/linux To: Tijl Coosemans Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 5BF466DE9C X-Spamd-Result: default: False [-3.85 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.995,0]; R_DKIM_ALLOW(-0.20)[gmail.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; IP_SCORE(-0.88)[ipnet: 2607:f8b0::/32(-2.56), asn: 15169(-1.73), country: US(-0.09)]; DKIM_TRACE(0.00)[gmail.com:+]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[5.3.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.96)[-0.964,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2018 20:10:39 -0000 > Note that these functions are normally used on uncacheable memory which > is strongly ordered on x86. There should be no reordering at all. On > PowerPC barrier instructions are needed to prevent reordering. Correct. The current lkpi implementation also assumes that device endian == host endian. The Linux generic accessors will do use endian macros to byte swap where necessary. The following change fixes radeon attach issues: https://github.com/POWER9BSD/freebsd/commit/be6c98f5c2e2ed9a4935ac5b67c468b75f3b4457