From owner-svn-src-head@freebsd.org  Sun May 22 02:52:19 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id AE80BB3B0BF
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Sun, 22 May 2016 02:52:19 +0000 (UTC)
 (envelope-from mailing-machine@vniz.net)
Received: from mail-lb0-f193.google.com (mail-lb0-f193.google.com
 [209.85.217.193])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 435F019C2
 for <svn-src-head@freebsd.org>; Sun, 22 May 2016 02:52:18 +0000 (UTC)
 (envelope-from mailing-machine@vniz.net)
Received: by mail-lb0-f193.google.com with SMTP id mx9so7414841lbb.2
 for <svn-src-head@freebsd.org>; Sat, 21 May 2016 19:52:18 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:subject:to:references:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-transfer-encoding;
 bh=cm2CZxXkYU2IicJHMe6FExtcQ1nEhROEagDaHKmLTy8=;
 b=NiQ4t7hByhsU5qEZQqar1S6rVnI0I+xYkHP9hIKNrxA3HJybvqAKttE070DkSN5/bK
 axXFlNIMV9YDgDru2G3UxhUgR7aDurrNX4N8ckVmq2MTB/aXpr31Oh+EspC21MUtMcty
 LomfwnD3BDMVJ4QLtDwyz7/6MsGqFIqoo50zeVwjyXlDoEy/6Dcl/9a00FA8qHY+oeBm
 bnnfIAMHOzFZrE+S/APRPNIHclaWlSt5Mwe6Au+c3kIvDpQqMETYEF2QoZaTVnoPMXPq
 jX7K4NIY2an+W5EMQbD79HhGytI7ahigO6TUkwlewiBm9TDOj7UUbns/e8sMWUsPnlr7
 p5dQ==
X-Gm-Message-State: AOPr4FUJcSSoEz7wFzsbzn77axi8zHhLh/nYGB3JPYpD03exMlX38NgIF0eHIM/EATYELA==
X-Received: by 10.112.65.71 with SMTP id v7mr3655138lbs.52.1463881566943;
 Sat, 21 May 2016 18:46:06 -0700 (PDT)
Received: from [192.168.1.2] ([89.169.173.68])
 by smtp.gmail.com with ESMTPSA id dw6sm4466361lbc.10.2016.05.21.18.46.05
 (version=TLSv1/SSLv3 cipher=OTHER);
 Sat, 21 May 2016 18:46:06 -0700 (PDT)
Subject: Re: svn commit: r300384 - head/sys/compat/ndis
To: "Pedro F. Giffuni" <pfg@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201605220029.u4M0TPI6050123@repo.freebsd.org>
From: Andrey Chernov <ache@freebsd.org>
Message-ID: <82b74a0b-7551-31ed-6b89-42925e072900@freebsd.org>
Date: Sun, 22 May 2016 04:46:03 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.0
MIME-Version: 1.0
In-Reply-To: <201605220029.u4M0TPI6050123@repo.freebsd.org>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 22 May 2016 02:52:19 -0000

On 22.05.2016 3:29, Pedro F. Giffuni wrote:
>  static void
>  srand(unsigned int seed)
>  {
>  
> +	if (seed == 0)
> +		seed = 1;
>  	srandom(seed);
>  }

IMHO it is not needed. srandom() already handles seed == 0 case, there
is no point to remap it to another constant.