From owner-freebsd-ports-bugs@freebsd.org Tue Jul 30 08:37:24 2019 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 372D7C44D0 for ; Tue, 30 Jul 2019 08:37:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 19DC790882 for ; Tue, 30 Jul 2019 08:37:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 17A44C44CF; Tue, 30 Jul 2019 08:37:24 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 17696C44CE for ; Tue, 30 Jul 2019 08:37:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EE6A690881 for ; Tue, 30 Jul 2019 08:37:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id C32DCE591 for ; Tue, 30 Jul 2019 08:37:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x6U8bN25055575 for ; Tue, 30 Jul 2019 08:37:23 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x6U8bNfD055574 for ports-bugs@FreeBSD.org; Tue, 30 Jul 2019 08:37:23 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 239293] fetch-list: broken handling of DISTFILES when it has entries with subdirectories Date: Tue, 30 Jul 2019 08:37:23 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: brigadir15@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Rspamd-Queue-Id: EE6A690881 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.984,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US] X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jul 2019 08:37:24 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D239293 --- Comment #6 from Ruslan Garipov --- Created attachment 206151 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D206151&action= =3Dedit Add `mkdir` to Tobias Kortkamp's v0 patch (In reply to Tobias Kortkamp from comment #4) Oh, sorry, I hastened to say ``the patch looks good''. Unfortunately, it doesn't fix the problem completely: it prevents mkdir(1) on fetch-list, but the result script itself ends up with issues: $ cd /usr/ports/lang/rush $ make fetch-list {elided} mkdir -p /usr/ports/distfiles/rust && cd /usr/ports/distfiles/rust && { env /usr/bin/fetch -Fpr -S 73812596 -o 2019-05-23/rustc-1.35.0-x86_64-unknown-freebsd.tar.gz https://static.rust-lang.org/dist/2019-05-23/rustc-1.35.0-x86_64-unknown-fr= eebsd.tar.gz ...{elided} mkdir -p /usr/ports/distfiles/rust && cd /usr/ports/distfiles/rust && { env /usr/bin/fetch -Fpr -S 83588135 -o 2019-05-23/rust-std-1.35.0-x86_64-unknown-freebsd.tar.gz https://static.rust-lang.org/dist/2019-05-23/rust-std-1.35.0-x86_64-unknown= -freebsd.tar.gz ... {elided} {elided} As one can see, the script generated by fetch-list creates /usr/ports/distfiles/rust directory, but fetch(1) writes its output to /usr/ports/distfiles/rust/2019-05-23 directory, which doesn't exist. Therefore, fetch(1) fails with errors like the following ones: fetch: 2019-05-23/rustc-1.35.0-x86_64-unknown-freebsd.tar.gz: open(): No su= ch file or directory fetch: 2019-05-23/rust-std-1.35.0-x86_64-unknown-freebsd.tar.gz: open(): No such file or directory Tobias, I've modified your patch slightly, and tested on lang/rust, shells/bash, www/firefox and x11/xorg (meta)port. For the former the new patch gives the following script: $ cd /usr/ports/lang/rust $ make fetch-list {the first row is elided} mkdir -p "/usr/ports/distfiles/rust/2019-05-23" && cd /usr/ports/distfiles/= rust && { env /usr/bin/fetch -Fpr -S 73812596 -o 2019-05-23/rustc-1.35.0-x86_64-unknown-freebsd.tar.gz https://static.rust-lang.org... {elided} {elided} which works fine on a machine having the Internet access. Are there any mandatory tests I should run against the updated do-fetch.sh script? --=20 You are receiving this mail because: You are on the CC list for the bug.=