From owner-svn-ports-all@freebsd.org Mon Nov 2 14:37:37 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4E4A1A02607; Mon, 2 Nov 2015 14:37:37 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) by mx1.freebsd.org (Postfix) with ESMTP id D700F179D; Mon, 2 Nov 2015 14:37:36 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id tGEiZUiabZ7CotGEjZ1WmL; Mon, 02 Nov 2015 07:37:30 -0700 X-Authority-Analysis: v=2.1 cv=W4fyL0ik c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=BWvPGDcYAAAA:8 a=VxmjJ2MpAAAA:8 a=qtqOOiqGOCEA:10 a=XldT38RWNwACPDQzwzUA:9 a=6I5d2MoRAAAA:8 a=ACPULtTEIhzUwNBugXYA:9 a=7Zwj6sZBwVKJAoWSPKxL6X1jA+E=:19 a=CjuIK1q_8ugA:10 a=66y7SloQAAAA:8 a=kjR-HvPHAAAA:8 a=4v9MTiH_lujrM-ItZV4A:9 a=YxBL1-UpAAAA:8 a=1uD52sVY3tjqBj_FW6cA:9 a=mnjMkT_jgaIA:10 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 75CF59B8B; Mon, 2 Nov 2015 06:37:28 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id tA2EbSnY069799; Mon, 2 Nov 2015 06:37:28 -0800 (PST) (envelope-from Cy.Schubert@komquats.com) Message-Id: <201511021437.tA2EbSnY069799@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.komquats.com/ To: marino@freebsd.org cc: Cy Schubert , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, hrs@freebsd.org Subject: Re: svn commit: r400565 - head/security/pam_krb5 In-Reply-To: Message from John Marino of "Mon, 02 Nov 2015 11:13:09 +0100." <56373735.2060906@marino.st> Mime-Version: 1.0 Content-Type: multipart/mixed ; boundary="==_Exmh_1446474983_106820" Date: Mon, 02 Nov 2015 06:37:28 -0800 X-CMAE-Envelope: MS4wfMY3+PGBDEYN4t6dR223A9zoS1cgSQnIU+5ZKo56eTjAgoIK6l3lOSRUi3bqisCdMkoYpRgBDPHESa31t3OW7UeNcLSOBZlxS5sk4unNwO2GvDQba6v+jb+qyl5m9mxZKgv+bVBo1zJ5Q0DXqzrup63CdYbUJ5mtarvmKkOc4iCmEuBvRqUOXDjqUMmo6NSecShzKv7OXJ9pHEbecDt4i3YMMBfktb+cjLMrtguz2tMlA6mUK7GIYoy0m3R8ack5/VMYn0prUs6GOaq4bsE7O9RFGmLd1tIahYx72FPXuD/tOSVnDf4O97+Qop2RXB5FptNIUKM4KthUaSAduV2/N6ZAal+yxg9aPLzD/0cgtuMT X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2015 14:37:37 -0000 This is a multipart MIME message. --==_Exmh_1446474983_106820 Content-Type: text/plain; charset=us-ascii In message <56373735.2060906@marino.st>, John Marino writes: > On 10/31/2015 6:58 AM, Cy Schubert wrote: > > Author: cy > > Date: Sat Oct 31 05:58:27 2015 > > New Revision: 400565 > > URL: https://svnweb.freebsd.org/changeset/ports/400565 > > > > Log: > > Fix Kerberos selection option and USES. > > > > Modified: > > head/security/pam_krb5/Makefile > > > > Hi Cy, > > This port is still broken. It won't build with heimdal-in-ports and it > did before. I double-checked by building in poudriere on FreeBSD with > that option selected. The krb5/krb5.h headers aren't found during > configuration and later it fails because of this. > > Can you either check that each options builds or revert the change the > broke the build? Looks like the tarball (port) never supported heimdal in ports in the first place. From ./configure: ac_fn_c_check_member "$LINENO" "krb5_creds" "session" "ac_cv_member_krb5_creds_s ession" " #if HAVE_KRB5_H # include #else # include #endif ./portable/krb5.h has the same code. Hiemdal in ports installs krb5.h ${LOCALBASE}/include/heimdal/krb5. I can remove the option for now or (better) we can symlink ${LOCALBASE}/include/heimdal to ${LOCALBASE}/include/krb5 in the heimdal port. See attached patch. --==_Exmh_1446474983_106820 Content-Type: text/plain ; name="heimdal.diff"; charset=us-ascii Content-Description: heimdal.diff Content-Disposition: attachment; filename="heimdal.diff" Index: Makefile =================================================================== --- Makefile (revision 400198) +++ Makefile (working copy) @@ -3,7 +3,7 @@ PORTNAME= heimdal PORTVERSION= 1.5.3 -PORTREVISION= 4 +PORTREVISION= 5 CATEGORIES= security ipv6 MASTER_SITES= http://www.h5l.org/dist/src/ \ http://ftp.pdc.kth.se/pub/heimdal/src/ \ @@ -103,6 +103,9 @@ ${INSTALL_DATA} ${FILESDIR}/kpasswdd-Makefile \ ${WRKSRC}/kpasswdd-cracklib/Makefile +post-install: + cd ${STAGEDIR}${LOCALBASE}/include && ${LN} -s heimdal krb5 + .if ${PORT_OPTIONS:MCRACKLIB} post-build: cd ${WRKSRC}/kpasswdd-cracklib && \ Index: pkg-plist =================================================================== --- pkg-plist (revision 400198) +++ pkg-plist (working copy) @@ -101,6 +101,7 @@ include/heimdal/wind.h include/heimdal/wind_err.h include/heimdal/xdbm.h +include/krb5 %%CRACKLIB%%lib/heimdal/kpasswdd-cracklib.so lib/heimdal/libasn1.a lib/heimdal/libasn1.so --==_Exmh_1446474983_106820 Content-Type: text/plain; charset=us-ascii Cheers, Cy Schubert or FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. --==_Exmh_1446474983_106820--