Date: Mon, 21 Jun 2004 18:00:21 GMT From: Pav Lucistnik <pav@FreeBSD.org> To: crollins666@hotmail.com, pav@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/68129: [maintainer-update]; port net/gtk-gnutella update to 0.93.4 Message-ID: <200406211800.i5LI0Lbt065864@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
Synopsis: [maintainer-update]; port net/gtk-gnutella update to 0.93.4 State-Changed-From-To: open->closed State-Changed-By: pav State-Changed-When: Mon Jun 21 17:57:58 GMT 2004 State-Changed-Why: Committed, with modifications. First, your WITHOUT_NLS haven't worked at all, so I removed it for now. You need to do more than this, at least pass a configure argument and conditionally remove .mo files from pkg-plist. Anyway, I think WITHOUT_NLS is not worthy here because gtk will always ever bring gettext in. Second, your handling of OPTIONS in ICU case was wrong. When an option is default on, you must check for WITHOUT_option. There are code paths when WITH[OUT]_* variables are not defined at all, and your port should behave in conformity with defaults. http://www.freebsd.org/cgi/query-pr.cgi?pr=68129
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200406211800.i5LI0Lbt065864>