From owner-freebsd-current@FreeBSD.ORG Tue Oct 11 22:08:20 2005 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B7C2616A420; Tue, 11 Oct 2005 22:08:20 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id F22FF43D46; Tue, 11 Oct 2005 22:08:16 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j9BM7nio026950; Tue, 11 Oct 2005 15:07:49 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j9BM7nHi026949; Tue, 11 Oct 2005 15:07:49 -0700 Date: Tue, 11 Oct 2005 15:07:49 -0700 From: Brooks Davis To: Andrew Thompson , Brooks Davis , Yar Tikhiy , Pawel Jakub Dawidek , FreeBSD Current Message-ID: <20051011220749.GD13461@odin.ac.hmc.edu> References: <20051005024903.GA72743@heff.fud.org.nz> <20051005203639.GA20552@garage.freebsd.pl> <20051005205515.GA30350@odin.ac.hmc.edu> <20051005210950.GB75848@heff.fud.org.nz> <20051009232849.GA27349@comp.chem.msu.su> <20051010022208.GA97249@heff.fud.org.nz> <20051010202900.GA24213@odin.ac.hmc.edu> <20051011210602.GA5714@heff.fud.org.nz> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LTeJQqWS0MN7I/qa" Content-Disposition: inline In-Reply-To: <20051011210602.GA5714@heff.fud.org.nz> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: Subject: Re: panic: ifc_free_unit: bit is already cleared X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2005 22:08:21 -0000 --LTeJQqWS0MN7I/qa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 12, 2005 at 10:06:02AM +1300, Andrew Thompson wrote: > On Mon, Oct 10, 2005 at 01:29:00PM -0700, Brooks Davis wrote: > > On Mon, Oct 10, 2005 at 03:22:08PM +1300, Andrew Thompson wrote: > > > On Mon, Oct 10, 2005 at 03:28:49AM +0400, Yar Tikhiy wrote: > > > > FWIW, I tried to look at the $subject problem since I had had it > > > > before, but just got a different panic: > > > >=20 > > > > Memory modified after free 0xc140b000(4092) val=3Ddeadc0dc = @ 0xc140b000 > > > > panic: Most recently used by clone > > > >=20 > > > > The clone code seems to have decremented something (refcount?) twice > > > > after freeing the memory chunk. > > >=20 > > > I have been testing this patch and I think it fixes all the problems > > > discussed. > > >=20 > > > It changes refcounting to count the number of cloned interfaces so > > > ifc_units is only freed when its safe. A new function has been added = to > > > decrement this when a simple cloner module is unloaded. The cloner is > > > still detached first to prevent the race. > > >=20 > > > In most cases the change is as simple as: > >=20 > > I don't see any reason why you can't just replace the specific destroy > > calls with calls to ifc_simple_destroy(). That would avoid expanding > > the API. >=20 > I have updated the patch and yes, its a nicer way to do it. Please > review. >=20 > Ive run through interations of create/kldunload with bridge, disc, > faith, gif, gre and ppp with extra printf's and its freeing correctly. This looks good to me, thanks for working on this and doing the _destory removals. Let's see about getting this committed. Slightly longer term I think should consider hanging the interface list off the cloner or maybe off some more generic per driver struct so if_clone_detach() can destroy the interfaces and the unload code becomes a one-liner in most cases. The current code is a result of not wanting to mess with the drivers too much initially, but I think we need to start looking at moving more bits into the support code. After all, if we only write something once instead of once per interface, that's a lot less opportunities to screw up. :) -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --LTeJQqWS0MN7I/qa Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFDTDe0XY6L6fI4GtQRAmHsAJ0fam9zzgO9GSog2U1+aVrKALjN7wCfSbHH kaolDnUHLNl6Mmg1RrWPD08= =/Kmv -----END PGP SIGNATURE----- --LTeJQqWS0MN7I/qa--