From owner-cvs-all@FreeBSD.ORG Mon Feb 18 19:30:43 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CB08016A418; Mon, 18 Feb 2008 19:30:43 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id 8B51A13C44B; Mon, 18 Feb 2008 19:30:43 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id 3FBA9209D; Mon, 18 Feb 2008 20:30:38 +0100 (CET) X-Spam-Tests: AWL X-Spam-Learn: disabled X-Spam-Score: -0.3/3.0 X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on tim.des.no Received: from ds4.des.no (des.no [80.203.243.180]) by smtp.des.no (Postfix) with ESMTP id BA8212084; Mon, 18 Feb 2008 20:30:37 +0100 (CET) Received: by ds4.des.no (Postfix, from userid 1001) id 5F5CD8449D; Mon, 18 Feb 2008 20:30:37 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Yar Tikhiy References: <200802141704.m1EH4VL4099009@repoman.freebsd.org> <86y79i5syt.fsf@ds4.des.no> <20080218142626.GI30694@comp.chem.msu.su> Date: Mon, 18 Feb 2008 20:30:37 +0100 In-Reply-To: <20080218142626.GI30694@comp.chem.msu.su> (Yar Tikhiy's message of "Mon\, 18 Feb 2008 17\:26\:26 +0300") Message-ID: <86k5l2rrj6.fsf@ds4.des.no> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_mount.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Feb 2008 19:30:43 -0000 Yar Tikhiy writes: > Dag-Erling Sm=C3=B8rgrav writes: > > Can you guarantee that this will not f*** up the bootp / dhcp + > > nfsroot case? There are dragons in that code which were decidedly > > not funny to track down and fix. > Indeed; or, as a Russian proverb has it, "Just don't touch the sh*t, > and it won't stink". :-) But, fortunately, I've just had a chance to > test this WRT the NFS_ROOT case. Thank Daemon, that code path is much > clearer now than it used to be in the 4.4BSD days. In other words, "no", or possibly "I don't want to answer your question". There are at least two quite different code paths that may lead to having an NFS-mounted root file system. Since you won't give me a proper answer, I have to assume that you only tested the easy one, i.e. pxeboot with a GENERIC kernel; and in that case, as the person who unf***ed both of the NFSROOT code paths the last time around, I support Craig's request to have this backed out and properly reviewed. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no