From nobody Thu Nov 30 17:01:02 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Sh2X60ph5z52JHq; Thu, 30 Nov 2023 17:01:10 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from glebi.us (glebi.us [162.251.186.162]) by mx1.freebsd.org (Postfix) with ESMTP id 4Sh2X55yLZz4Yhp; Thu, 30 Nov 2023 17:01:09 +0000 (UTC) (envelope-from glebius@freebsd.org) Authentication-Results: mx1.freebsd.org; none Received: by glebi.us (Postfix, from userid 1000) id BABF374F9C; Thu, 30 Nov 2023 09:01:02 -0800 (PST) Date: Thu, 30 Nov 2023 09:01:02 -0800 From: Gleb Smirnoff To: Mike Karels Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: cfb1e92912b4 - main - sockets: don't malloc/free sockaddr memory on accept(2) Message-ID: References: <202311301634.3AUGYljD055413@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US] X-Rspamd-Queue-Id: 4Sh2X55yLZz4Yhp On Thu, Nov 30, 2023 at 10:56:23AM -0600, Mike Karels wrote: M> On 30 Nov 2023, at 10:34, Gleb Smirnoff wrote: M> M> > The branch main has been updated by glebius: M> > M> > URL: https://cgit.FreeBSD.org/src/commit/?id=cfb1e92912b4cf75360b7fbe86197cc29bc212c1 M> > M> > commit cfb1e92912b4cf75360b7fbe86197cc29bc212c1 M> > Author: Gleb Smirnoff M> > AuthorDate: 2023-11-30 16:30:55 +0000 M> > Commit: Gleb Smirnoff M> > CommitDate: 2023-11-30 16:30:55 +0000 M> > M> > sockets: don't malloc/free sockaddr memory on accept(2) M> > M> > Let the accept functions provide stack memory for protocols to fill it in. M> > Generic code should provide sockaddr_storage, specialized code may provide M> > smaller structure. M> M> Does this mean that families cannot support sockaddrs bigger than sockaddr_storage? M> In particular, does local domain (aka unix domain)? Did it before? Yes, but I assume sockaddr_storage should cover anything: (kgdb) p sizeof(struct sockaddr_un) $1 = 106 (kgdb) p sizeof(struct sockaddr_storage) $2 = 128 Please correct me if I'm wrong. -- Gleb Smirnoff