From nobody Tue Sep 9 15:57:56 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cLpPc5mGtz675vM; Tue, 09 Sep 2025 15:57:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cLpPc5Jgjz48sv; Tue, 09 Sep 2025 15:57:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757433476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rZIMmNo7p4kkpRUkvyrI6HaMOoYcyVXMvvPjkRrNfcE=; b=QHNyFIFEEDspoFBzFetohsojEHkhcdZe+hVcuScO3cUfVsRmC3KFx88WqMJ+vXiJrCHwzN 6qyALEFw2MzWhEK60rAe9lta1jEHe/WNuwI53df97jUDAW/EntmjnULx1DwsWWZDnpR+Hy Q3qcXNgSazoJHYg86j+ur0UX6+549BgYATTro6Tz/nz+EUmQfkdjHW136CNW2GWQuheLHK cGwJ6Cz8jrJGu4KDx4yD9EHyjL7OWVBvAcmHWFCMu7BCOagz6gLknmJ/FTIPnQHmxPUqA4 Z+L7QIacVdUkeDePEkZFjA1fACeg2f690N3b/wX9tvmoTUP8SlVUJqnweG1vxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757433476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rZIMmNo7p4kkpRUkvyrI6HaMOoYcyVXMvvPjkRrNfcE=; b=KowNw/1BIx/NDhx2jz7oxBTL8qrXyCWQBXoCmicTjbDa6Jk1dbgk+2WkUP/iaDpqRaIu+7 8pNG5EhOGmZI00xml978omamiDfvJVhAEXS+NcZ5yctxBYwQXluPRQ6SWZIZoMcpu91z2Y Y1Kkiv30mBV+N7kcztnWEmy5bW8PfhG+Xhz3aCjDtL9bbh+HaVqw07spACyRvav9li5rBH ToGIGp3wQOcIvfOV9HWetrT6oYZRPB8WcxbOD3yrcsbB4rNOE+0p2Z82QCrKMX6aMRjqH/ 7RqT92zwkM/QIRTiQ3t151PapMG5oQ66fcPptGKOcg2mvLcLKVxxYdKJ0Q+aQQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1757433476; a=rsa-sha256; cv=none; b=usGJRaQ8EJr3Q7s7V8gm58Q1SUIFJmUKyGCT1Rf3XHdF/nOckazaj71bQ/Q3RirpJYrsH6 +Kk5z4IWZyewc8yHwJQqEdRD8HlMEOncmmuDUJ3VbKCkgcUAVDWZTmk6vh8U8WZdFroPuM hrb3d3CbWOGsGgGbjhvj0je0EGhcMYa9KuiXLlF0Mq0vqa3XtUYtukuLzhYMh9U1AInuHb PIH4X6S5X8JVxZi2G2NlmR661qJOXEuVAMfjrJiAFUie6JoetRf3FF+B7h9CJvC8Yd09jm DcibiJ9MyVlSy5CeYgU/U7FTCUxwUQ5cNWQrgICk7v6mmPsr+V0HnX+aM/Cghg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cLpPc4dtKzjyg; Tue, 09 Sep 2025 15:57:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 589FvuWh039173; Tue, 9 Sep 2025 15:57:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 589FvuC8039170; Tue, 9 Sep 2025 15:57:56 GMT (envelope-from git) Date: Tue, 9 Sep 2025 15:57:56 GMT Message-Id: <202509091557.589FvuC8039170@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: de974a0f1b73 - main - ddb ps: Print again the effective GID, separately List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: de974a0f1b73e79466c25f3c85fe727004576fea Auto-Submitted: auto-generated The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=de974a0f1b73e79466c25f3c85fe727004576fea commit de974a0f1b73e79466c25f3c85fe727004576fea Author: Olivier Certner AuthorDate: 2025-08-26 08:56:54 +0000 Commit: Olivier Certner CommitDate: 2025-09-09 15:56:40 +0000 ddb ps: Print again the effective GID, separately Following commit be1f7435ef218b1d ("kern: start tracking cr_gid outside of cr_groups[]"), cr_groups[] doesn't contain the effective GID anymore. Fix the 'show proc' DDB command to show it again, and make it stand out with respect to the supplementary ones. Fixes: be1f7435ef218b1d ("kern: start tracking cr_gid outside of cr_groups[]") MFC after: 9 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D52251 --- sys/ddb/db_ps.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/sys/ddb/db_ps.c b/sys/ddb/db_ps.c index 733c440f5ee3..a26cf8161294 100644 --- a/sys/ddb/db_ps.c +++ b/sys/ddb/db_ps.c @@ -459,12 +459,11 @@ DB_SHOW_COMMAND(proc, db_show_proc) db_printf("??? (%#x)\n", p->p_state); } if (p->p_ucred != NULL) { - db_printf(" uid: %d gids: ", p->p_ucred->cr_uid); - for (i = 0; i < p->p_ucred->cr_ngroups; i++) { - db_printf("%d", p->p_ucred->cr_groups[i]); - if (i < (p->p_ucred->cr_ngroups - 1)) - db_printf(", "); - } + db_printf(" uid: %d gid: %d supp gids: ", + p->p_ucred->cr_uid, p->p_ucred->cr_gid); + for (i = 0; i < p->p_ucred->cr_ngroups; i++) + db_printf(i == 0 ? "%d" : ", %d", + p->p_ucred->cr_groups[i]); db_printf("\n"); } if (p->p_pptr != NULL)