Date: Sun, 14 May 2017 12:37:45 +0200 From: =?iso-8859-1?Q?Jos=E9_G=2E?= Juanino <jjuanino@gmail.com> To: ports@freebsd.org Subject: Re: Standard way to run test target in specific port Message-ID: <20170514103745.mnuvr3bvkrr2opdi@abel.home.inet> In-Reply-To: <20170514091325.76yi5rxb2a2tjs53@abel.home.inet> References: <20170514091325.76yi5rxb2a2tjs53@abel.home.inet>
next in thread | previous in thread | raw e-mail | index | archive | help
El domingo 14 de mayo a las 11:13:25 CEST, José G. Juanino escribió:
>Hello FreeBSD ports!
>
>I am porting a backup software (bup backup), and the upstream Makefile
>has a "test" target. I find useful to make a port knob to allow run
>such test (disabled by default). What is the best way to accomplish
>that task? Is there any doc or "best practique" to watch for?
>
>I am thinking in write something like this:
>
>
>RUNTEST_DESC= Run test suite # knob
>
>.....
>
>.if ${PORT_OPTIONS:MRUNTEST}
>post-build:
> ${GMAKE} ${MAKE_ARGS} -C ${WRKDIR}/${PORTNAME}-${PORTVERSION} test
>.endif
>
>
>But it seems very contrived and ugly.
>
>
>You can find the full shar file in 219174 (with no test target
>deployed).
Hi again, I will try to answer to myself ...
I have defined the "RUNTEST" knob in "OPTIONS_DEFINE" variable, and
after:
RUNTEST_VARS= TEST_TARGET=test
The last line enable the "do-test" target properly when the knob is set
(see bsd.port.mk system Makefile)
But I do not know how to invoke automatically that target when user just
run "make". Indeed I am thinking if really is a good idea to force the
execution of "make test" by mean of the knob ... In some other ports I
am seeing, this is enterelly optional.
Regards
--
José G. Juanino
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170514103745.mnuvr3bvkrr2opdi>