From owner-soc-status@freebsd.org Thu Jun 14 13:58:50 2018 Return-Path: Delivered-To: soc-status@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E20551006EDB for ; Thu, 14 Jun 2018 13:58:49 +0000 (UTC) (envelope-from akshay1994.leo@gmail.com) Received: from mail-lf0-f68.google.com (mail-lf0-f68.google.com [209.85.215.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 60F6E6BA90; Thu, 14 Jun 2018 13:58:49 +0000 (UTC) (envelope-from akshay1994.leo@gmail.com) Received: by mail-lf0-f68.google.com with SMTP id i83-v6so9600192lfh.5; Thu, 14 Jun 2018 06:58:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kkU70euK0WETvJCOWH6M8H+CrcTVEaCcNykdbSIvufQ=; b=OSbO9yMBitqzrdP6PdBWCSUzv0dQhI87SPdw+KqLa/UJHvDMuCKXBv8LtX2J4Fm26Z xvAthWXNtIFSfZhm8lNKccElwQanrnCWSd5XA8pvofbBRyP6VBWViom5Kc0EFVIvIh2O 8j+o+sU0uyrCo/NPhhxARPBrTNNizh6aaV4ss6lElIFZ16RNuBYoJk3irITR65vQUuZ1 /i54lgwG3zsPusc8UbQovIfARtVopsy+o/IQTIcDbdHZ87s5poLPrdR963az1NbKOC65 4isCzQe2SQ9NZFPCY56nEecV5BuwxQeY4mWvq69bqjXwYadQO1XzDOnY2PO6iw9K+Oxk sGKw== X-Gm-Message-State: APt69E38N6W9k3E11eqDbWDfFTYV5PLgAkoHkpbJS4gHinOxQp30HO7N wuuamzkfiXHwTHaS3aGTALYGODfD X-Google-Smtp-Source: ADUXVKIz2nUpxVJtuAXqg7cHyxW2JAgUx2EoCPwEun1KzMpm/o3lC7QEYbY1oa2W2h1D9PdX+349cA== X-Received: by 2002:a2e:2161:: with SMTP id h94-v6mr2020174ljh.58.1528984387264; Thu, 14 Jun 2018 06:53:07 -0700 (PDT) Received: from mail-lf0-f44.google.com (mail-lf0-f44.google.com. [209.85.215.44]) by smtp.gmail.com with ESMTPSA id g14-v6sm1067019lfb.36.2018.06.14.06.53.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Jun 2018 06:53:06 -0700 (PDT) Received: by mail-lf0-f44.google.com with SMTP id o9-v6so9582636lfk.1; Thu, 14 Jun 2018 06:53:06 -0700 (PDT) X-Received: by 2002:a19:13da:: with SMTP id 87-v6mr6451462lft.80.1528984386777; Thu, 14 Jun 2018 06:53:06 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Jaggi Date: Thu, 14 Jun 2018 14:52:55 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [Week 4] Import the Xen grant-table bus_dma(9) handlers from OpenBSD To: Pratyush Yadav Cc: soc-status@freebsd.org, Edward Napierala Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: soc-status@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Summer of Code Status Reports and Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2018 13:58:50 -0000 Hi Pratyush, On Mon, 11 Jun 2018 at 12:48, Pratyush Yadav wrote: > Hi, > > This week I finished up my implementation of the xen-specific > bus_dma(9) handlers. I asked Roger Pau Monne for review. After his > review, I realized I had been doing things a little wrong. I was > building the Xen-specific handlers on top of the bus_dma(9) interface. > Instead, I should have created an alternate busdma implementation, > kind of like sys/x86/iommu/busdma_dmar.c > > So I had to study the inner details of the bus_dma(9) interface to > learn how an alternate implementation can be written. This was a > little confusing at the beginning.because there is no clear guide on > the subsystem for beginners like me. But eventually, I got the hang of > it, mostly by reading code already written. > > This is really good work. :) > After that came the task of rewriting my implementation. I wrote it, > and then spent a couple of days refining it. Today, I submitted it to > Roger again for review. We are discussing it as of now. No major > concerns have been raised so I should be done with the xen-specific > busdma hooks in a few days. > > You can check out the code at [0]. > Since Roger is already reviewing the code, you are in good hands. I've nitpicked on few small style and consistency issues. Regards, Akshay > > I maintain a blog on Blogger where I publish my progress every few > days. Check it out if you want more details on what I'm doing [1]. > > > [0] https://github.com/prati0100/freebsd > > [1] > http://pratyushgsoc.blogspot.in/2018/05/import-xen-grant-table-busdma9-handlers.html > > -- > Regards, > Pratyush Yadav >