From owner-freebsd-current@FreeBSD.ORG Fri Jan 31 23:45:11 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 38B2D86B; Fri, 31 Jan 2014 23:45:11 +0000 (UTC) Received: from mail-pd0-x229.google.com (mail-pd0-x229.google.com [IPv6:2607:f8b0:400e:c02::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 017AE15DB; Fri, 31 Jan 2014 23:45:10 +0000 (UTC) Received: by mail-pd0-f169.google.com with SMTP id v10so4870643pde.28 for ; Fri, 31 Jan 2014 15:45:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:mime-version:in-reply-to:content-type :content-transfer-encoding:message-id:cc:from:subject:date:to; bh=D+JK9NVa6RLC9MxCsfTnX1wa38Tv9nNZto5gYTNldsU=; b=KEzQpEn/WG58di1FSEzk4hL4XgM+216RDkJ/UJlPOTW2twNt3MWp3S0UttkWWVijGM uwkyKrkc3enyKGfYWep5FGQkc0JrcKfq5357k2iwWtToDZf68Ni6nwgwHWEYWUQRfM3I qaC8tVb3OVuaqVBc0O/gYO8iJZE0ckMbOkeBX6kuYQau4WUof7aYePPTrIeQFynqHHLm Gr5WZcB9B2YET+Ng+IsMIFA84M4NlhOywHQ6GAFITj1qLStwYpP1xU+iR0wMdewxCZiQ dNMdt2fVdyVjciiiFIrGZvN/2tTXZv4NzwfAa+bbZDdzbQKroQYaCCe1BH//bBYbfyG5 NQbA== X-Received: by 10.68.35.129 with SMTP id h1mr23657487pbj.163.1391211910622; Fri, 31 Jan 2014 15:45:10 -0800 (PST) Received: from [172.20.10.6] ([112.96.101.138]) by mx.google.com with ESMTPSA id xv2sm31442378pbb.39.2014.01.31.15.45.06 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 31 Jan 2014 15:45:08 -0800 (PST) References: <52E8DDA3.3070301@bitfrost.no> <52E9F546.9090005@bitfrost.no> <52EB4DBE.20501@bitfrost.no> <52EC07CE.70608@freebsd.org> <52EC2889.9020107@bitfrost.no> Mime-Version: 1.0 (1.0) In-Reply-To: <52EC2889.9020107@bitfrost.no> Content-Type: text/plain; charset=gb2312 Content-Transfer-Encoding: quoted-printable Message-Id: <38C22813-14E0-45A2-80CC-ED17525F6B95@gmail.com> X-Mailer: iPhone Mail (11B554a) From: =?GB2312?Q?"=BB=C6=CE=C4=BB=D4=40Gmail"?= Subject: Re: Apple Trackpad driver Date: Sat, 1 Feb 2014 07:45:03 +0800 To: Hans Petter Selasky Cc: "Danilo E. Gondolfo" , "freebsd-current@freebsd.org" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jan 2014 23:45:11 -0000 Hi Hans, Yes, I wrote wsp base on atp(4) and bcm5974.c from Linux. Of course we can a= dd a notice about that. Table and some structure bt_data, tp_finger from Lin= ux, I only wrote wsp_intr_callback base on usbdump, all other part should be= belong to Hans. Cheers, Huang Wen Hui > =D4=DA 2014=C4=EA2=D4=C21=C8=D5=A3=AC6:49=A3=ACHans Petter Selasky =D0=B4=B5=C0=A3=BA >=20 >> On 01/31/14 21:30, Danilo E. Gondolfo wrote: >>> On 01/31/14 05:16, Hans Petter Selasky wrote: >>>> On 01/31/14 02:46, Huang Wen Hui wrote: >>>> Hi Hans, >>>>=20 >>>> pos_x[] is not non-inialized, it may be previous pos_x, it is still >>>> ok for >>>> getting dx. >>>> "n" var is trying to reduce "untouch" sensor data for post >>>> proccessing. I >>>> attach a new patch >>>> may be more clear, also fixed unexpected movement when button status or= >>>> ntouch changing. >>>>=20 >>>> Cheers, >>>>=20 >>>> Huang Wen Hui >>>=20 >>> Hi, >>>=20 >>> http://svnweb.freebsd.org/changeset/base/261315 >>>=20 >>> --HPS >>=20 >> Good work! >>=20 >> I noticed that your driver is based on the Linux driver [1] and some >> pieces of code are copied, are you sure that we won't have any problems >> with license? >>=20 >> These changes can be (should be) merged in the driver atp(4), no? >>=20 >> Danilo. >>=20 >>=20 >> [1] - http://lxr.free-electrons.com/source/drivers/input/mouse/bcm5974.c >=20 > Hi, >=20 > It looks to me like some tables have been copied. We probably should add a= notice about that. The rest of the code looks OK to me. >=20 > Huang, any comments? >=20 > --HPS >=20