From owner-freebsd-bugs  Wed Sep 27  6:40:10 2000
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 30B4537B423
	for <freebsd-bugs@FreeBSD.org>; Wed, 27 Sep 2000 06:40:01 -0700 (PDT)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id GAA51655;
	Wed, 27 Sep 2000 06:40:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 1BC5C37B423; Wed, 27 Sep 2000 06:38:47 -0700 (PDT)
Message-Id: <20000927133847.1BC5C37B423@hub.freebsd.org>
Date: Wed, 27 Sep 2000 06:38:47 -0700 (PDT)
From: vova@express.ru
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-1.0
Subject: bin/21595: lpd don't set socket option SO_REUSEADDR on inet socket
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         21595
>Category:       bin
>Synopsis:       lpd don't set socket option SO_REUSEADDR on inet socket
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep 27 06:40:00 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     Vladimir B. Grebenschikov
>Release:        5.0-CURRENT
>Organization:
TSB "Russian Express"
>Environment:
FreeBSD vbook.express.ru 4.1.1-STABLE FreeBSD 4.1.1-STABLE #0: Tue Sep 26 15:39:07 MSD 2000     root@vbook.express.ru:/ext/releng4/src/sys/compile/VBOOK  i386

>Description:
lpd don't set socket option SO_REUSEADDR on inet socket
so it is not possible to start lpd just after stop
>How-To-Repeat:
lpd; sleep 1; killall lpd; lpd

last lpd will not started with complain in log:
Sep 27 17:15:40 gw lpd[54009]: bind: Address already in use

>Fix:
--- usr.sbin/lpr/lpd/lpd.c.orig Wed Sep 27 17:26:01 2000
+++ usr.sbin/lpr/lpd/lpd.c      Wed Sep 27 17:33:29 2000
@@ -285,6 +285,11 @@
        if (pflag == 0) {
                finet = socket(AF_INET, SOCK_STREAM, 0);
                if (finet >= 0) {
+                       int one = 1;
+                       if (setsockopt(finet, SOL_SOCKET, SO_REUSEADDR, &one, sizeof(one)) < 0) {
+                               syslog(LOG_ERR, "setsockopt (SO_REUSEADDR): %m");
+                               mcleanup(0);
+                       }
                        if (options & SO_DEBUG &&
                            setsockopt(finet, SOL_SOCKET, SO_DEBUG, 0, 0) < 0) {
                                syslog(LOG_ERR, "setsockopt (SO_DEBUG): %m");


>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message