From owner-svn-src-head@FreeBSD.ORG Tue Oct 21 21:21:15 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B368710656A3; Tue, 21 Oct 2008 21:21:15 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 3303A8FC1C; Tue, 21 Oct 2008 21:21:15 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m9LLL8vv008548; Tue, 21 Oct 2008 17:21:09 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Scott Long Date: Tue, 21 Oct 2008 17:02:21 -0400 User-Agent: KMail/1.9.7 References: <200810211851.m9LIptwg006141@svn.freebsd.org> <48FE41D2.90602@samsco.org> In-Reply-To: <48FE41D2.90602@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200810211702.21348.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Tue, 21 Oct 2008 17:21:09 -0400 (EDT) X-Virus-Scanned: ClamAV 0.93.1/8465/Tue Oct 21 16:14:56 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184135 - head/sys/dev/ata X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Oct 2008 21:21:15 -0000 On Tuesday 21 October 2008 04:55:46 pm Scott Long wrote: > John Baldwin wrote: > > Author: jhb > > Date: Tue Oct 21 18:51:55 2008 > > New Revision: 184135 > > URL: http://svn.freebsd.org/changeset/base/184135 > > > > Log: > > Restore the default maximum segment size for the bus dma tag to 64k as it > > is in 6.x and 7.x. The typo caused 64k transactions to be unnecessarily > > split up into two PRD entries. > > > > Modified: > > head/sys/dev/ata/ata-dma.c > > > > Modified: head/sys/dev/ata/ata-dma.c > > ============================================================================== > > --- head/sys/dev/ata/ata-dma.c Tue Oct 21 18:50:52 2008 (r184134) > > +++ head/sys/dev/ata/ata-dma.c Tue Oct 21 18:51:55 2008 (r184135) > > @@ -78,7 +78,7 @@ ata_dmainit(device_t dev) > > ch->dma.unload = ata_dmaunload; > > ch->dma.alignment = 2; > > ch->dma.boundary = 65536; > > - ch->dma.segsize = 63536; > > + ch->dma.segsize = 65536; > > ch->dma.max_iosize = 128 * DEV_BSIZE; > > ch->dma.max_address = BUS_SPACE_MAXADDR_32BIT; > > ch->dma.dma_slots = 6; > > Not having a multiple-of-512 transfer size is likely more responsible > for data corruption than having a transfer size near 64k. This was only in HEAD though since the SATA port multiplier changes. The code in 6.x and 7.x that we were seeing data corruption with at work on Dell 1435's never had this bug. -- John Baldwin