From owner-svn-src-head@freebsd.org  Mon Aug 10 07:55:27 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 74CD899EBFB;
 Mon, 10 Aug 2015 07:55:27 +0000 (UTC)
 (envelope-from julian@freebsd.org)
Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "vps1.elischer.org",
 Issuer "CA Cert Signing Authority" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4E23F1C6;
 Mon, 10 Aug 2015 07:55:26 +0000 (UTC)
 (envelope-from julian@freebsd.org)
Received: from Julian-MBP3.local
 (50-196-156-133-static.hfc.comcastbusiness.net [50.196.156.133])
 (authenticated bits=0)
 by vps1.elischer.org (8.14.9/8.14.9) with ESMTP id t7A7tFBs012045
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);
 Mon, 10 Aug 2015 00:55:18 -0700 (PDT)
 (envelope-from julian@freebsd.org)
Subject: Re: svn commit: r286458 - in head/sys: net netinet netinet6
To: "Alexander V. Chernikov" <melifaro@FreeBSD.org>,
 src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
References: <201508081815.t78IF0xJ081015@repo.freebsd.org>
From: Julian Elischer <julian@freebsd.org>
Message-ID: <55C858DD.7060202@freebsd.org>
Date: Mon, 10 Aug 2015 15:55:09 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0)
 Gecko/20100101 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <201508081815.t78IF0xJ081015@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Aug 2015 07:55:27 -0000

On 8/9/15 2:15 AM, Alexander V. Chernikov wrote:
> Author: melifaro
> Date: Sat Aug  8 18:14:59 2015
> New Revision: 286458
> URL: https://svnweb.freebsd.org/changeset/base/286458
>
> Log:
>    MFP r274295:
>    
>    * Move interface route cleanup to route.c:rt_flushifroutes()
>    * Convert most of "for (fibnum = 0; fibnum < rt_numfibs; fibnum++)" users
>      to use new rt_foreach_fib() instead of hand-rolling cycles.

I think rt_foreach_fib() is poorly named. My expectation is that it 
would call a function for each fib,
or be a macro that just iterates fibs, rather than actually walking 
the tree.

rt_foreach_fib_walk() maybe.


>
> Mod