From owner-svn-src-head@FreeBSD.ORG  Mon Feb 15 23:17:45 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 02B4E1065676;
	Mon, 15 Feb 2010 23:17:45 +0000 (UTC) (envelope-from sam@errno.com)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.freebsd.org (Postfix) with ESMTP id C74E28FC18;
	Mon, 15 Feb 2010 23:17:44 +0000 (UTC)
Received: from ice.local ([10.0.0.115]) (authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id o1FNHhRY085760
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Mon, 15 Feb 2010 15:17:44 -0800 (PST) (envelope-from sam@errno.com)
Message-ID: <4B79D617.2010009@errno.com>
Date: Mon, 15 Feb 2010 15:17:43 -0800
From: Sam Leffler <sam@errno.com>
User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
MIME-Version: 1.0
To: Rui Paulo <rpaulo@FreeBSD.org>
References: <201002151847.o1FIlg38083805@svn.freebsd.org>
In-Reply-To: <201002151847.o1FIlg38083805@svn.freebsd.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-DCC-sonic.net-Metrics: ebb.errno.com; whitelist
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r203933 - head/sys/dev/ath/ath_hal/ar5416
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Feb 2010 23:17:45 -0000

Rui Paulo wrote:
> Author: rpaulo
> Date: Mon Feb 15 18:47:42 2010
> New Revision: 203933
> URL: http://svn.freebsd.org/changeset/base/203933
> 
> Log:
>   Fix KITE version check.
>   
>   Obtained from:	//depot/user/rpaulo/80211n/...
> 
> Modified:
>   head/sys/dev/ath/ath_hal/ar5416/ar5416reg.h
> 
> Modified: head/sys/dev/ath/ath_hal/ar5416/ar5416reg.h
> ==============================================================================
> --- head/sys/dev/ath/ath_hal/ar5416/ar5416reg.h	Mon Feb 15 18:46:02 2010	(r203932)
> +++ head/sys/dev/ath/ath_hal/ar5416/ar5416reg.h	Mon Feb 15 18:47:42 2010	(r203933)
> @@ -613,12 +613,12 @@
>  	(AR_SREV_KITE(ah) && \
>  	 AH_PRIVATE((_ah))->ah_macRev == AR_XSREV_REVISION_KITE_11)
>  #define	AR_SREV_KITE_11_OR_LATER(_ah) \
> -	(AH_PRIVATE((_ah))->ah_macVersion >= AR_XSREV_VERSION_KITE || \
> +	(AR_SREV_KITE_11(_ah) || \
>  	 AH_PRIVATE((_ah))->ah_macRev >= AR_XSREV_REVISION_KITE_11)
>  #define	AR_SREV_KITE_12(_ah) \
>  	(AR_SREV_KITE(ah) && \
> -	 AH_PRIVATE((_ah))->ah_macRev == AR_XSREV_REVISION_KITE_12)
> +	 AH_PRIVATE((_ah))->ah_macRev >= AR_XSREV_REVISION_KITE_12)

Should this be named AR_SREV_KITE_12_OR_LATER?  or is the change wrong?

>  #define	AR_SREV_KITE_12_OR_LATER(_ah) \
> -	(AH_PRIVATE((_ah))->ah_macVersion >= AR_XSREV_VERSION_KITE || \
> +	(AR_SREV_KITE_12(_ah) || \
>  	 AH_PRIVATE((_ah))->ah_macRev >= AR_XSREV_REVISION_KITE_12)
>  #endif /* _DEV_ATH_AR5416REG_H */
> 
>