From owner-freebsd-hackers Sun Aug 29 3:41:13 1999 Delivered-To: freebsd-hackers@freebsd.org Received: from arnold.neland.dk (mail.neland.dk [194.255.12.232]) by hub.freebsd.org (Postfix) with ESMTP id 4087014C40 for ; Sun, 29 Aug 1999 03:40:59 -0700 (PDT) (envelope-from leifn@neland.dk) Received: from localhost (localhost [127.0.0.1]) by arnold.neland.dk (8.9.3/8.9.3) with ESMTP id MAA09562; Sun, 29 Aug 1999 12:40:21 +0200 (CEST) (envelope-from leifn@neland.dk) Date: Sun, 29 Aug 1999 12:40:20 +0200 (CEST) From: Leif Neland To: Sheldon Hearn Cc: Doug , freebsd-hackers@FreeBSD.ORG Subject: Re: Please review: rc file changes In-Reply-To: <57667.935757215@axl.noc.iafrica.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, 27 Aug 1999, Sheldon Hearn wrote: > > Hi folks, > > What follows is a diff that presents Doug's changes (which must have > required quite a bit of effort, thanks!) in a slightly different format > which I think the grumpies here might prefer. > > Specifically, case statements look more like what a lot of folks are > used to seeing, and conditionals that don't need to be case sensitive > have not been converted to case statements. > > I think the effort which Doug has put into this is great and would make > for a better rc. It's a pity that a few cosmetic issues generated so > much pooh-pooh'ing. :-( > It seems to me the changes are mostly cosmetic anyway, so naturally people complain about the cosmetics. I don't thing the [Yy][Ee][Ss] stuff is really nessecary. This is unix, and unix is case-sensitive. It should be obvious that the options is either YES or NO. Anyway, if it is so, I think readability (if that's important) could be made by adding two functions: isyes and isno, to be used as if isyes ${thisvariable} case $1 of [Yy][Ee][Ss]) exit 0 ;; *) exit 1 ;; esac Leif To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message