From owner-freebsd-usb@FreeBSD.ORG Thu Apr 19 00:54:45 2007 Return-Path: X-Original-To: freebsd-usb@freebsd.org Delivered-To: freebsd-usb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1FB6416A401 for ; Thu, 19 Apr 2007 00:54:45 +0000 (UTC) (envelope-from freebsdusb@bindone.de) Received: from mail.bindone.de (sidewinder.bindone.de [62.146.109.98]) by mx1.freebsd.org (Postfix) with SMTP id 7498D13C45D for ; Thu, 19 Apr 2007 00:54:44 +0000 (UTC) (envelope-from freebsdusb@bindone.de) Received: (qmail 32270 invoked from network); 19 Apr 2007 00:50:44 -0000 Received: from unknown (HELO bombat.bindone.de) (84.151.222.109) by mail.bindone.de with SMTP; 19 Apr 2007 00:50:44 -0000 Message-ID: <4626BDC2.7060904@bindone.de> Date: Thu, 19 Apr 2007 02:54:26 +0200 From: grem User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.8.1.2) Gecko/20070318 SeaMonkey/1.1.1 MIME-Version: 1.0 To: freebsd-usb@freebsd.org References: <200703290011.l2T0BAKa035949@www.freebsd.org> <200704051307.56065.hselasky@c2i.net> <46165FAD.2030707@bindone.de> <200704061744.07179.hselasky@c2i.net> In-Reply-To: <200704061744.07179.hselasky@c2i.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: usb/110988: [patch] Handling of quirk IGNORE_RESIDUE is umass.c is broken X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2007 00:54:45 -0000 Hans Petter Selasky wrote: > On Friday 06 April 2007 16:56, grem wrote: >> Hans Petter Selasky wrote: >>> On Wednesday 04 April 2007 16:09, grem wrote: >>>> Hi, >>>> >>>> is there any way to get this into the source tree? >>> Yes, I can take this patch into the P4 tree if you change it a little >>> bit. >>> >>> I want this invalid residue detection to be all automatic: >>> >>> If the first residue you get is invalid, then it should use the USB >>> transfer counts for residue for the rest of the lifetime of the device. >>> Else it should use the standard invalid residue check. >>> >>> --HPS >> Imho we should support both, so that devices which are so broken that we >> can't detect the invalid residue (like I tried to point out before) still >> have the quirk so force it manually. > > Ok, no problem, but like Alexander Leidinger pointed out, the current flag > does not do anything, and should be removed from a couple of devices. > >> Can you do the autodetection on your own or do you want me to do the change >> to the patch and repost it so you can review? I have only one broken USB >> device, so if anyone out there has access to more it would be extremely >> helpful. > > I can make a patch for this, and send it to you for testing, during the next > week. > > --HPS Any progress? :)