From owner-svn-src-all@FreeBSD.ORG Wed Jul 22 10:13:24 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CEE9F1065672; Wed, 22 Jul 2009 10:13:24 +0000 (UTC) (envelope-from artis.caune@gmail.com) Received: from mail-bw0-f219.google.com (mail-bw0-f219.google.com [209.85.218.219]) by mx1.freebsd.org (Postfix) with ESMTP id F1E038FC19; Wed, 22 Jul 2009 10:13:23 +0000 (UTC) (envelope-from artis.caune@gmail.com) Received: by bwz19 with SMTP id 19so73903bwz.43 for ; Wed, 22 Jul 2009 03:13:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=cNwb8aI090K7GEfmQAVUlFD0NGbUlq6idpz+b5v++iU=; b=fR6YohdTQ1ELmsuLe1p2bPnopI6vY3T+QjtQn9LGJUWgowvfdV5muQMhbKGNgwdZl6 CjV7K6EWrPsA072J8J644z5XzWgYbzFOg2X/nngS5F6IjfRVYOQpdkPg7tte9wflUBB9 ofI4L5i4FvCyvIgEwxVVR9/vrPIa8Tk2ycTCA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=gknS09M4SLjm5tVeQO6y2GAqpzy4ZXaCSx5PE4fZ5FC2mqslXN+Cmik5LPJfGAPjy9 XHufsm23aQ/Ax/PzVZLKW+PmEffMjgtJBfnkraGMfNStetQWbEHDk+fX6mk23obuPn3X tQUJ5aK5mfem6aUQZr3/KWUH5XJ8/eOZUxLHY= MIME-Version: 1.0 Received: by 10.103.167.14 with SMTP id u14mr357849muo.38.1248256071751; Wed, 22 Jul 2009 02:47:51 -0700 (PDT) In-Reply-To: <200907201916.n6KJGhEl086253@svn.freebsd.org> References: <200907201916.n6KJGhEl086253@svn.freebsd.org> Date: Wed, 22 Jul 2009 12:47:51 +0300 Message-ID: <9e20d71e0907220247x3b8b75cdm59106eaadc1517fa@mail.gmail.com> From: Artis Caune To: Edward Tomasz Napierala Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r195785 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2009 10:13:25 -0000 2009/7/20 Edward Tomasz Napierala : > Author: trasz > Date: Mon Jul 20 19:16:42 2009 > New Revision: 195785 > URL: http://svn.freebsd.org/changeset/base/195785 > > Log: > =C2=A0Fix permission handling for extended attributes in ZFS. =C2=A0Witho= ut > =C2=A0this change, ZFS uses SunOS Alternate Data Streams semantics - each > =C2=A0EA has its own permissions, which are set at EA creation time > =C2=A0and - unlike SunOS - invisible to the user and impossible to change= . > =C2=A0From the user point of view, it's just broken: sometimes access > =C2=A0is granted when it shouldn't be, sometimes it's denied when > =C2=A0it shouldn't be. > > =C2=A0This patch makes it behave just like UFS, i.e. depend on current > =C2=A0file permissions. =C2=A0Also, it fixes returned error codes (ENOATT= R > =C2=A0instead of ENOENT) and makes listextattr(2) return 0 instead > =C2=A0of EPERM where there is no EA directory (i.e. the file never had > =C2=A0any EA). I can not create archives from ZFS file system after this commit. # tar -c -f /dev/null -C /tmp ./ tar: Out of memory: Cannot allocate memory extattr_list_link(0x8010150a0,0x1,0x0,0x0,0x50f738,0x8e008) =3D -1098808089680 (0xffffff0029ef23b0) mmap(0x0,703594496,PROT_READ|PROT_WRITE,MAP_PRIVATE|MAP_ANON,-1,0x0) ERR#12 'Cannot allocate memory' tar: write(2,"tar: ",5) =3D 5 (0x5) Out of memorywrite(2,"Out of memory",13) =3D 13 (0xd) --=20 Artis Caune Everything should be made as simple as possible, but not simpler.