From owner-p4-projects@FreeBSD.ORG  Mon Mar  3 17:22:32 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 130F01065677; Mon,  3 Mar 2008 17:22:32 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C5EDE1065673;
	Mon,  3 Mar 2008 17:22:31 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 961E98FC1A;
	Mon,  3 Mar 2008 17:22:31 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m23HKPmR051512;
	Mon, 3 Mar 2008 10:20:25 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Mon, 03 Mar 2008 10:20:53 -0700 (MST)
Message-Id: <20080303.102053.1091030337.imp@bsdimp.com>
To: rrs@FreeBSD.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <200803031313.m23DDJv0034582@repoman.freebsd.org>
References: <200803031313.m23DDJv0034582@repoman.freebsd.org>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: perforce@FreeBSD.org
Subject: Re: PERFORCE change 136737 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Mar 2008 17:22:32 -0000

In message: <200803031313.m23DDJv0034582@repoman.freebsd.org>
            "Randall R. Stewart" <rrs@FreeBSD.org> writes:
: http://perforce.freebsd.org/chv.cgi?CH=136737
: 
: Change 136737 by rrs@rrs-mips2-jnpr on 2008/03/03 13:13:06
: 
: 	Found real source of PG_G problem, the proper intial
: 	       value for a CACHED page is PG_CACHE not PG_CACHED. 
: 	       PG_CACHED is defined in vm to be 1, where as PG_CACHE
: 	       is 0x18 (the proper value for us and defined in pte.h).
: 
: Affected files ...
: 
: .. //depot/projects/mips2-jnpr/src/sys/mips/include/pte.h#5 edit
: 
: Differences ...
: 
: ==== //depot/projects/mips2-jnpr/src/sys/mips/include/pte.h#5 (text+ko) ====
: 
: @@ -110,8 +110,8 @@
:  #define	PG_UNCACHED	0x00000010
:  #define	PG_CACHE	0x00000018
:  #define	PG_CACHEMODE	0x00000038
: -#define	PG_ROPAGE	(PG_V | PG_RO | PG_CACHED) /* Write protected */
: -#define	PG_RWPAGE	(PG_V | PG_M | PG_CACHED)  /* Not wr-prot not clean */
: +#define	PG_ROPAGE	(PG_V | PG_RO | PG_CACHE) /* Write protected */
: +#define	PG_RWPAGE	(PG_V | PG_M | PG_CACHE)  /* Not wr-prot not clean */
:  #define	PG_CWPAGE	(PG_V | PG_CACHED)	   /* Not wr-prot but clean */
:  #define	PG_IOPAGE	(PG_G | PG_V | PG_M | PG_UNCACHED)
:  #define	PG_FRAME	0x3fffffc0
: 

We should audit all the PG_CACHE vs PG_CACHED stuff, and maybe change
PG_CACHED to PG_PAGE_CACHED and PG_UNCACHED to PG_PAGE_UNCACHED...

Warner