From owner-cvs-src@FreeBSD.ORG Wed Oct 22 08:44:09 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C480016A4B3; Wed, 22 Oct 2003 08:44:09 -0700 (PDT) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id B503A43FAF; Wed, 22 Oct 2003 08:44:08 -0700 (PDT) (envelope-from sam@errno.com) Received: from 66.127.85.91 ([66.127.85.91]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.9) with ESMTP id h9MFi50x001493 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Wed, 22 Oct 2003 08:44:07 -0700 (PDT) (envelope-from sam@errno.com) From: Sam Leffler Organization: Errno Consulting To: Hajimu UMEMOTO , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Date: Wed, 22 Oct 2003 08:45:31 -0700 User-Agent: KMail/1.5.3 References: <200310221532.h9MFWusl093984@repoman.freebsd.org> In-Reply-To: <200310221532.h9MFWusl093984@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200310220845.31046.sam@errno.com> Subject: Re: cvs commit: src/sys/netinet6 frag6.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2003 15:44:09 -0000 On Wednesday 22 October 2003 08:32 am, Hajimu UMEMOTO wrote: > ume 2003/10/22 08:32:56 PDT > > FreeBSD src repository > > Modified files: > sys/netinet6 frag6.c > Log: > pretect ip6 reassemble queue by use of mutex. > > Submitted by: rwatson (with modification) The convention used throughout the kernel is for FOO_LOCK_ASSERT() to generate an assertion that the specified lock is held. It would be good for the IPv6 code to do likewise (you appear to be using FOO_LOCK_CHECK instead). Sam