From owner-cvs-src@FreeBSD.ORG Tue Apr 26 18:29:50 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F268C16A4D2 for ; Tue, 26 Apr 2005 18:29:49 +0000 (GMT) Received: from mail23.sea5.speakeasy.net (mail23.sea5.speakeasy.net [69.17.117.25]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6150243D2F for ; Tue, 26 Apr 2005 18:29:49 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 7205 invoked from network); 26 Apr 2005 18:29:49 -0000 Received: from server.baldwin.cx ([216.27.160.63]) (envelope-sender )AES256-SHA encrypted SMTP for ; 26 Apr 2005 18:29:48 -0000 Received: from roboboy.corp.weather.com (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id j3QITfvQ034307; Tue, 26 Apr 2005 14:29:42 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: David Xu Date: Tue, 26 Apr 2005 11:43:56 -0400 User-Agent: KMail/1.8 References: <200504190811.j3J8BSdx072259@repoman.freebsd.org> In-Reply-To: <200504190811.j3J8BSdx072259@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200504261143.58152.jhb@FreeBSD.org> X-Spam-Status: No, score=-102.8 required=4.2 tests=ALL_TRUSTED, USER_IN_WHITELIST autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2005 18:29:50 -0000 On Tuesday 19 April 2005 04:11 am, David Xu wrote: > davidxu 2005-04-19 08:11:28 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_sig.c > Log: > Oops, forgot to update this file. > Fix a race condition between kern_wait() and thread_stopped(). > Problem is in kern_wait(), parent process steps through children list, > once a child process is skipped, and later even if the child is stopped, > parent process still sleeps in msleep(), the race happens if parent > masked SIGCHLD. > > Submitted by : Peter Edwards peadar.edwards at gmail dot com > MFC after : 4 days You're not setting P_STOPPED_SIG anymore, is that on purpose? -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org