From owner-freebsd-current Mon Jul 14 02:19:14 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id CAA10193 for current-outgoing; Mon, 14 Jul 1997 02:19:14 -0700 (PDT) Received: from helbig.informatik.ba-stuttgart.de (rvc1.informatik.ba-stuttgart.de [141.31.112.22]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id CAA10178 for ; Mon, 14 Jul 1997 02:19:09 -0700 (PDT) Received: (from helbig@localhost) by helbig.informatik.ba-stuttgart.de (8.8.6/8.8.5) id LAA04825; Mon, 14 Jul 1997 11:18:58 +0200 (MET DST) From: Wolfgang Helbig Message-Id: <199707140918.LAA04825@helbig.informatik.ba-stuttgart.de> Subject: Re: some forgotten submits In-Reply-To: <199707140846.SAA09257@genesis.atrad.adelaide.edu.au> from Michael Smith at "Jul 14, 97 06:16:54 pm" To: msmith@atrad.adelaide.edu.au (Michael Smith) Date: Mon, 14 Jul 1997 11:18:56 +0200 (MET DST) Cc: helbig@MX.BA-Stuttgart.De, msmith@atrad.adelaide.edu.au, FreeBSD-current@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL30 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-current@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Hi, > Checking on a NetBSD machine, they have the same problem. Given you > have a fix for the problem, do you know what actually caused it to > manifest with the changes I brought in? Sorry, English is not my native language, so I'm afraid I have to guess the meaning of your question. Here is the answer to the guessed question. The bug is in search.c and every program that uses libedit and the search function in it will have the bug. /bin/sh is just an example, another one should be the new ftp(1) -- I didn't check it. In search.c strcpy(3) is replaced by strncpy(3). But n is set to the size of a pointer, i. e. four, instead of to the size of the buffer the pointer points to. > > I'll incorporate your change, or a modified version of it, later this > evening. Thank you :-) Wolfgang