From owner-freebsd-current Tue Sep 28 5:58:36 1999 Delivered-To: freebsd-current@freebsd.org Received: from ns.oeno.com (ns.oeno.com [194.100.99.145]) by hub.freebsd.org (Postfix) with SMTP id 1BC1C14DB3 for ; Tue, 28 Sep 1999 05:58:33 -0700 (PDT) (envelope-from will@ns.oeno.com) Received: (qmail 17845 invoked by uid 1001); 28 Sep 1999 12:58:31 -0000 Date: 28 Sep 1999 12:58:31 -0000 Message-ID: <19990928125831.17843.qmail@ns.oeno.com> From: Ville-Pertti Keinonen To: phk@critter.freebsd.dk Cc: current@FreeBSD.ORG, culverk@culverk.student.umd.edu In-reply-to: <25864.938522052@critter.freebsd.dk> (message from Poul-Henning Kamp on Tue, 28 Sep 1999 14:34:12 +0200) Subject: Re: just found this Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > >If you want to include the other attack I mentioned (I just tried it, > >got up to > 160000 vnodes), then you have to exclude vnodes that are > >only live because of v_cache_src entries from the count. > > It should probably only count vnodes in "actual" use. There's no counter for that currently. Counting non-zero v_usecount vs. non-zero v_holdcnt separately would be reasonably easy. Actual use obviously shouldn't include cached data. Can you say off the top of your head whether v_holdcnt applies to anything other than v_cache_src and non-VM buffer-cache (struct buf) stuff? If not, then v_usecount == 0 could be considered non-use without worrying about v_holdcnt, since most vnodes with cached data are going to have an associated vm_object holding a real reference. > >BTW: You still haven't committed the v_id patch I sent you in May. Is > >there any specific reason for this? > > I seem to remember we stalled on some detail which wouldn't or > couldn't work was it NFS ? No, there was a completely unrelated NFS bug I ran into while looking into it (which has been fixed), the last comment from you seemed to imply that you were going to commit the patch. There were lots of details that needed further attention in my experiments for actually deallocating vnodes, but those patches certainly weren't supposed to be committed. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message