Date: Tue, 14 Nov 2023 14:02:33 -0400 From: Joseph Mingrone <jrm@FreeBSD.org> To: Marius Strobl <marius@freebsd.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: d12bc36e7698 - main - cpu-microcode-intel: Add knobs for RC RUN_DEPENDS and split files Message-ID: <865y24mcw6.fsf@phe.ftfl.ca> In-Reply-To: <ZVOqKjb7UkxusLKt@btk.zeist.de> (Marius Strobl's message of "Tue, 14 Nov 2023 18:11:06 %2B0100") References: <202311092025.3A9KPJhe049861@gitrepo.freebsd.org> <867cmld31m.fsf@phe.ftfl.ca> <ZVOqKjb7UkxusLKt@btk.zeist.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-= Content-Type: text/plain On Tue, 2023-11-14 at 18:11, Marius Strobl <marius@freebsd.org> wrote: > On Mon, Nov 13, 2023 at 12:35:33PM -0400, Joseph Mingrone wrote: >> On Thu, 2023-11-09 at 20:25, Marius Strobl <marius@FreeBSD.org> wrote: >> > The branch main has been updated by marius: >> > URL: https://cgit.FreeBSD.org/ports/commit/?id=d12bc36e7698f3737de1ac228bd49eab10cf1bb0 >> > commit d12bc36e7698f3737de1ac228bd49eab10cf1bb0 >> > Author: Marius Strobl <marius@FreeBSD.org> >> > AuthorDate: 2023-11-09 20:20:53 +0000 >> > Commit: Marius Strobl <marius@FreeBSD.org> >> > CommitDate: 2023-11-09 20:20:53 +0000 >> > cpu-microcode-intel: Add knobs for RC RUN_DEPENDS and split files >> > Split UCODE files as well as dependency on sysutils/cpu-microcode-rc >> > are only required for use with cpucontrol(8) and update method two >> > respectively. The first method needs neither so we can spare a few >> > MiB and a superfluous port. >> > Given that the automatic update method one is superior, the RC knob >> > should be deprecated and removed eventually. At that point, split >> > UCODE files still will be useful for developers and if users want >> > to update the microcode without a reboot (but otherwise rely on the >> > loader for automatic updates, i. e. method one). >> For the reasons you described, I proposed removing the RC script for the >> Intel CPU microcode updates [1]. However, there was a reasonable >> argument for keeping it. As you say, users may still want to update >> their Intel CPU microcode this way because updates can be applied on a >> running system without requiring downtime for a reboot. >> With your commit, I think we have a good compromise. Users who really >> want to save a bit of space and have one fewer port installed can turn >> off these two knobs. Maybe we could make that the default. >> Joe >> [1] See the comments in https://reviews.freebsd.org/D32349 for details. > Hi Joe, > it's probably a matter of taste but when it does come to something > like updating UCODE on a running - likely critical as otherwise I'd > simply reboot with the new firmware in place - system, I typically > feel uneasy and want to know exactly what's going to be done. For > me, this translates to - as mentioned earlier - using cpucontrol(8) > directly, i. e. issuing: > # echo /dev/cpuctl* | xargs -n 1 cpucontrol -u > instead of a 77 lines of code for microcode_update on top of 175 > lines of script for service(8). IMO that's also not particularly > more cryptic of harder to remember than: > # service microcode_update onestart > In any case, as previously stated there's no need to employ the > RC script for manual updates either and least as far as I'm > concerned, running cpucontrol(8) directly instead is preferable. > Thus, I propose to at least switch the default. But I leave that > decision up to you. > Marius Hi Marius, Those are valid points. Let's leave this thread open for about a month and if no one objects to turning those knobs off by default, I'll make the change. Thanks, Joe --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKkBAEBCgCOFiEEVbCTpybDiFVxIrrVNqQMg7DW754FAmVTtjlfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1 QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUQHGpybUBmcmVl YnNkLm9yZwAKCRA2pAyDsNbvnokFD/4uLW4u22q2AEnjGb0nUuu6fLm7Hl3ydQHN 8AoaMs3xUsbqoY2cnalvBgWt7OltZkvkUOe+HVxXa2/xv0wwZInJDTwfVyDaXL8O f95OGhmYyjdFD8+13mJMSRjzpLOO32Lgkp78teQB2SpM5VwiGklJrpqpZA6kLmz/ 5OP9FStZ2EFnI9f2p8G5NWOSxM8OII0Fux19/UEb71d8ygEPj1Ear60Srzz35I+Z Y8NIBHyK19athuPXS3ZWoGwG5mF8fqPa/24BncobfVfMdjrEIpUjLa/wLcVvrGJL IGC+yVOfiRYwgHJVt7oo+R4A2A1qah/QfL+ASno3U7HoR/VVqDOE5k6VCpj09cGA AY+kODAbc2LKe++4tbakrX2jERTW9fwuMCcWoxrL1cVlDF8rTDN2sxg2JthoEo8t 4Dow68Kc1n5mcnW2c8dy23eJIxeRg9+9sOe8MV8+WNC4B02GWvUPg9SISQbsekFr vJcYl7WV/3oI91EE4nzoyNAtaa8wLCODNWQSgblUWiC0qBs8fCPi6YxVT58rjHzk VMwuCYm1CG2cemYRpeqO/nq8EgJKz3VgpvBdv7yjIbaPhetvdRSGrqhYWQu6qo4j B5DxxIBglPDjb7J1F8nButaLCaGI4SH0+QEK1IFwVIMBIWqtrqYhXbgeZpFFcjoO fMOv9wpgAw== =svo8 -----END PGP SIGNATURE----- --=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?865y24mcw6.fsf>