Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 21 Jun 2016 05:11:19 +0000 (UTC)
From:      Sepherosa Ziehau <sephe@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r302043 - in stable/10/sys/dev/hyperv: netvsc storvsc vmbus
Message-ID:  <201606210511.u5L5BJLa086904@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: sephe
Date: Tue Jun 21 05:11:19 2016
New Revision: 302043
URL: https://svnweb.freebsd.org/changeset/base/302043

Log:
  MFC 298041,298259
  
  298041
      hyperv: No need to zero out softc
  
      MFC after:  1 week
      Sponsored by:       Microsoft OSTC
  
  298259
      hyperv: Remove two assign-only local variables
  
      Submitted by:       Jun Su <junsu microsoft com>
      MFC after:  1 week
      Sponsored by:       Microsoft OSTC

Modified:
  stable/10/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
  stable/10/sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c
  stable/10/sys/dev/hyperv/vmbus/hv_channel_mgmt.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
==============================================================================
--- stable/10/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c	Tue Jun 21 05:02:03 2016	(r302042)
+++ stable/10/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c	Tue Jun 21 05:11:19 2016	(r302043)
@@ -434,7 +434,6 @@ netvsc_attach(device_t dev)
 
 	sc = device_get_softc(dev);
 
-	bzero(sc, sizeof(hn_softc_t));
 	sc->hn_unit = unit;
 	sc->hn_dev = dev;
 

Modified: stable/10/sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c
==============================================================================
--- stable/10/sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c	Tue Jun 21 05:02:03 2016	(r302042)
+++ stable/10/sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c	Tue Jun 21 05:11:19 2016	(r302043)
@@ -1014,8 +1014,6 @@ storvsc_attach(device_t dev)
 		goto cleanup;
 	}
 
-	bzero(sc, sizeof(struct storvsc_softc));
-
 	/* fill in driver specific properties */
 	sc->hs_drv_props = &g_drv_props_table[stor_type];
 

Modified: stable/10/sys/dev/hyperv/vmbus/hv_channel_mgmt.c
==============================================================================
--- stable/10/sys/dev/hyperv/vmbus/hv_channel_mgmt.c	Tue Jun 21 05:02:03 2016	(r302042)
+++ stable/10/sys/dev/hyperv/vmbus/hv_channel_mgmt.c	Tue Jun 21 05:11:19 2016	(r302043)
@@ -375,12 +375,6 @@ vmbus_channel_on_offer(hv_vmbus_channel_
 
 	offer = (hv_vmbus_channel_offer_channel*) hdr;
 
-	hv_guid *guidType;
-	hv_guid *guidInstance;
-
-	guidType = &offer->offer.interface_type;
-	guidInstance = &offer->offer.interface_instance;
-
 	// copy offer data
 	copied = malloc(sizeof(*copied), M_DEVBUF, M_NOWAIT);
 	if (copied == NULL) {

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201606210511.u5L5BJLa086904>