From owner-cvs-all Mon May 13 4:28:32 2002 Delivered-To: cvs-all@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id ECB5C37B405; Mon, 13 May 2002 04:28:19 -0700 (PDT) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.2/8.12.2) with ESMTP id g4DBRcHA013233; Mon, 13 May 2002 13:27:38 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Luigi Rizzo Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_ethersubr.c src/sys/netinet ip_dummynet.c ip_dummynet.h In-Reply-To: Your message of "Mon, 13 May 2002 04:26:19 PDT." <20020513042619.A30792@iguana.icir.org> Date: Mon, 13 May 2002 13:27:38 +0200 Message-ID: <13232.1021289258@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20020513042619.A30792@iguana.icir.org>, Luigi Rizzo writes: >On Mon, May 13, 2002 at 12:47:43PM +0200, Poul-Henning Kamp wrote: >... >> But couldn't you easily add a new rulechain for the ethernet >> rules ? That seems both clean and simple to me ? > >yes, in fact this is probably what i will end up doing. >Just trying to figure out what to put in the ip_fw struct to >instruct the kernel to link the rule in the other chain. > >> Besides, if we want to clean up, 5.0 is the time to do it... > >there is more to that. After looking at how bloated the code has >become, i have definitely come to the conclusion that we have two >choices here (not mutually exclusive): Even better yet: + Make the ipfw program a "ipfw rule to C compiler" and kldload the compiled C code. BillF has worked on this and the performance increase was fantastic. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message