From nobody Sun Feb 15 11:19:11 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fDNhc1c4rz6SWNy for ; Sun, 15 Feb 2026 11:19:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fDNhb74dRz4QMy for ; Sun, 15 Feb 2026 11:19:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771154352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aCxauvOpZ7bin5uiwMVWUY/6M+uXcF8m48hClZdsYCo=; b=Wk8izDx5QvEfZBQ+ca8axhovXHM+FBsT/z/gkq4NtjNuFPcGQVwMnW2vRhxwC/yTxUDB75 /hWhaUro6YFZvtHHA1B9baT/WZuAwcVm0LRI45OjRtgxhTXTE14tStxU1fwpMo9OPpoeCJ MDQhsLJmuburgYYoDPhi3UV2z8z/vMHSfKaZksQIbF9TpRhzJBz15/siK8FHOsilUup99m kLdfeTHJAtrdJ6OKfSkUpnD5aDjC56UOczEOxd+cXu4TlJynSMPiMmULTrvWWxfJiuMIlF vpit9iRepN9dlbGwpddsjeLoFtUj30brqXzUr3x88xMEOfAX3tJ77nvJ/jm6vQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771154352; a=rsa-sha256; cv=none; b=t2HCEP3K8IjzIzeaxcyEFI16ph2XuZr+XeNdAnO7hMjHhA/vPqBM2QgAAF2NZC+cZA2MXH c8cMNdgOPALLLm9mJNXGphXSToYgbpCGWPRnp/KASRTYAeUgLKdRraB4KPiEsZRDHtRWLd TYGcErDBDWN5vQOKWHADgPVetf3KeeWimRdVBVkZoJ1NxQfU2TAhWJFk0MSPP3d2yfmhJ8 3ptZSb0cGXRNKuzliJqnLclRRgqoyC9DYaqznADMgbCqAhbswl6wA/RJnV6heDlRPaLWkn 70cA5pwGC/e0GUXmIaFyn9FOdIE7ugFDparNkZKAkIea3LQmLrfd4XRexoEcMA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771154352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aCxauvOpZ7bin5uiwMVWUY/6M+uXcF8m48hClZdsYCo=; b=K7IinfUs7tsyx0MNhNX5wpbjfxJObtj8TAPSi6dRRpU4syHmRcain8NPhlCXqcAp4xtyKS 8WWja3DnJlPv1iQKzsxtp3jjwHIjaFFCybb9XxOIKamT2FfKHCX82IOsV8Biut6vFx1s2M JHMeuxYYI2dEmaaH+Bxo1t+mYzPmDC6VdORBxodyZ8qTbkh6UbSUglFveMBNcR3wSLfl1q croydRKLhBw5Re9O5sXj0vr3Byt5wCFGEhwNBJoLYcvKWhU+WyJgf+exACp52kvop4Q1Ja Y4B70KfYhKHDyXlQ0bL9dg8C2yhRk1sMw29461t+D6ami38xydkmTKlPym+pHA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fDNhb2fTCzrgJ for ; Sun, 15 Feb 2026 11:19:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 34511 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 15 Feb 2026 11:19:11 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Osipov Subject: git: 6ce85d64d059 - stable/13 - daemon: Add option for output file mode List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: michaelo X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 6ce85d64d0594ce540c92fddfb89065c13546f23 Auto-Submitted: auto-generated Date: Sun, 15 Feb 2026 11:19:11 +0000 Message-Id: <6991abaf.34511.5fbb3ea5@gitrepo.freebsd.org> The branch stable/13 has been updated by michaelo: URL: https://cgit.FreeBSD.org/src/commit/?id=6ce85d64d0594ce540c92fddfb89065c13546f23 commit 6ce85d64d0594ce540c92fddfb89065c13546f23 Author: Michael Osipov AuthorDate: 2026-01-28 18:49:26 +0000 Commit: Michael Osipov CommitDate: 2026-02-15 11:17:22 +0000 daemon: Add option for output file mode The daemon utility has always created its output file with a fixed mode of 0600. This causes issues for log collection setups where the collector does not run as root but instead relies on group access to the watched daemon’s log file. Introduce a new option that allows specifying the output file mode using install(1)-style semantics. This enables non-root log collectors to access the file as intended and improves compatibility with log rotation tools. Reviewed by: kevans MFC after: 1 week Relnotes: yes Differential Revision: https://reviews.freebsd.org/D54930 (cherry picked from commit a3b90a1f008365d9f62773998f89f9c872e2bed5) --- usr.sbin/daemon/daemon.8 | 17 +++++++++++++++-- usr.sbin/daemon/daemon.c | 28 +++++++++++++++++++++------- 2 files changed, 36 insertions(+), 9 deletions(-) diff --git a/usr.sbin/daemon/daemon.8 b/usr.sbin/daemon/daemon.8 index fce08bc90e62..a1a56de03d4a 100644 --- a/usr.sbin/daemon/daemon.8 +++ b/usr.sbin/daemon/daemon.8 @@ -24,7 +24,7 @@ .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" SUCH DAMAGE. .\" -.Dd September 18, 2023 +.Dd January 28, 2026 .Dt DAEMON 8 .Os .Sh NAME @@ -98,10 +98,23 @@ or both This value specifies what is sent to syslog and the log file. The default is .Cm 3 . +.It Fl M , Fl -output-file-mode Ar mode +Specify the file +.Ar mode +to use when creating the +.Pa output_file . +The mode is interpreted using +.Xr chmod 1 +style semantics. +This option is useful when the daemonized process or external log +collectors require group or world access to the output file. +The default is +.Cm 0600 . .It Fl o , Fl -output-file Ar output_file Append output from the daemonized process to .Pa output_file . -If the file does not exist, it is created with permissions 0600. +If the file does not exist, it is created with the default file +.Ar mode . When this option is used together with options .Fl -change-dir and diff --git a/usr.sbin/daemon/daemon.c b/usr.sbin/daemon/daemon.c index 73524e3bd286..c83d9ed8f35c 100644 --- a/usr.sbin/daemon/daemon.c +++ b/usr.sbin/daemon/daemon.c @@ -86,13 +86,14 @@ struct daemon_state { int syslog_facility; int keep_fds_open; int output_fd; + mode_t output_file_mode; bool restart_enabled; bool syslog_enabled; bool log_reopen; }; static void restrict_process(const char *); -static int open_log(const char *); +static int open_log(const char *, mode_t); static void reopen_log(struct daemon_state *); static bool listen_child(int, struct daemon_state *); static int get_log_mapping(const char *, const CODE *); @@ -109,7 +110,7 @@ static int daemon_setup_kqueue(void); static int pidfile_truncate(struct pidfh *); -static const char shortopts[] = "+cfHSp:P:ru:o:s:l:t:m:R:T:h"; +static const char shortopts[] = "+cfHSp:P:ru:o:M:s:l:t:m:R:T:h"; static const struct option longopts[] = { { "change-dir", no_argument, NULL, 'c' }, @@ -117,6 +118,7 @@ static const struct option longopts[] = { { "sighup", no_argument, NULL, 'H' }, { "syslog", no_argument, NULL, 'S' }, { "output-file", required_argument, NULL, 'o' }, + { "output-file-mode", required_argument, NULL, 'M' }, { "output-mask", required_argument, NULL, 'm' }, { "child-pidfile", required_argument, NULL, 'p' }, { "supervisor-pidfile", required_argument, NULL, 'P' }, @@ -136,7 +138,7 @@ usage(int exitcode) { (void)fprintf(stderr, "usage: daemon [-cfHrS] [-p child_pidfile] [-P supervisor_pidfile]\n" - " [-u user] [-o output_file] [-t title]\n" + " [-u user] [-o output_file] [-M output_file_mode] [-t title]\n" " [-l syslog_facility] [-s syslog_priority]\n" " [-T syslog_tag] [-m output_mask] [-R restart_delay_secs]\n" "command arguments ...\n"); @@ -147,6 +149,7 @@ usage(int exitcode) " --sighup -H Close and re-open output file on SIGHUP\n" " --syslog -S Send output to syslog\n" " --output-file -o Append output of the child process to file\n" + " --output-file-mode -M Output file mode of the child process\n" " --output-mask -m What to send to syslog/file\n" " 1=stdout, 2=stderr, 3=both\n" " --child-pidfile -p Write PID of the child process to file\n" @@ -168,6 +171,7 @@ main(int argc, char *argv[]) { char *p = NULL; int ch = 0; + mode_t *set = NULL; struct daemon_state state; daemon_state_init(&state); @@ -229,6 +233,15 @@ main(int argc, char *argv[]) */ state.mode = MODE_SUPERVISE; break; + case 'M': + if ((set = setmode(optarg)) == NULL) { + errx(6, "unrecognized output file mode: %s", optarg); + } else { + state.output_file_mode = getmode(set, 0); + } + free(set); + set = NULL; + break; case 'p': state.child_pidfile = optarg; state.mode = MODE_SUPERVISE; @@ -293,7 +306,7 @@ main(int argc, char *argv[]) } if (state.output_filename) { - state.output_fd = open_log(state.output_filename); + state.output_fd = open_log(state.output_filename, state.output_file_mode); if (state.output_fd == -1) { err(7, "open"); } @@ -726,10 +739,10 @@ do_output(const unsigned char *buf, size_t len, struct daemon_state *state) } static int -open_log(const char *outfn) +open_log(const char *outfn, mode_t outfm) { - return open(outfn, O_CREAT | O_WRONLY | O_APPEND | O_CLOEXEC, 0600); + return open(outfn, O_CREAT | O_WRONLY | O_APPEND | O_CLOEXEC, outfm); } static void @@ -737,7 +750,7 @@ reopen_log(struct daemon_state *state) { int outfd; - outfd = open_log(state->output_filename); + outfd = open_log(state->output_filename, state->output_file_mode); if (state->output_fd >= 0) { close(state->output_fd); } @@ -771,6 +784,7 @@ daemon_state_init(struct daemon_state *state) .keep_fds_open = 1, .output_fd = -1, .output_filename = NULL, + .output_file_mode = 0600 }; }