From owner-svn-src-head@freebsd.org Tue Dec 10 08:28:19 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C918A1D3479; Tue, 10 Dec 2019 08:28:19 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from vtr.rulingia.com (vtr.rulingia.com [IPv6:2001:19f0:5801:ebe:5400:1ff:fe53:30fd]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vtr.rulingia.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47XCr14NMGz4bSR; Tue, 10 Dec 2019 08:28:17 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from server.rulingia.com (ppp239-208.static.internode.on.net [59.167.239.208]) by vtr.rulingia.com (8.15.2/8.15.2) with ESMTPS id xBA8S1JQ053759 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Dec 2019 19:28:07 +1100 (AEDT) (envelope-from peter@rulingia.com) X-Bogosity: Ham, spamicity=0.000000 Received: from server.rulingia.com (localhost.rulingia.com [127.0.0.1]) by server.rulingia.com (8.15.2/8.15.2) with ESMTPS id xBA8RtQ2041652 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 10 Dec 2019 19:27:55 +1100 (AEDT) (envelope-from peter@server.rulingia.com) Received: (from peter@localhost) by server.rulingia.com (8.15.2/8.15.2/Submit) id xBA8RtSO041651; Tue, 10 Dec 2019 19:27:55 +1100 (AEDT) (envelope-from peter) Date: Tue, 10 Dec 2019 19:27:55 +1100 From: Peter Jeremy To: Michal Meloun Cc: Kyle Evans , src-committers , svn-src-all , svn-src-head Subject: Re: svn commit: r355487 - in head/sys: arm64/arm64 arm64/include conf Message-ID: <20191210082755.GA31003@server.rulingia.com> References: <201912071614.xB7GENQ3080793@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WIyZ46R2i8wDzkSu" Content-Disposition: inline In-Reply-To: X-PGP-Key: http://www.rulingia.com/keys/peter.pgp User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 47XCr14NMGz4bSR X-Spamd-Bar: ------- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of peter@rulingia.com designates 2001:19f0:5801:ebe:5400:1ff:fe53:30fd as permitted sender) smtp.mailfrom=peter@rulingia.com X-Spamd-Result: default: False [-7.72 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[rulingia.com]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-3.32)[ip: (-9.65), ipnet: 2001:19f0:5800::/38(-4.83), asn: 20473(-2.08), country: US(-0.05)]; TO_DN_ALL(0.00)[]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:20473, ipnet:2001:19f0:5800::/38, country:US]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Dec 2019 08:28:19 -0000 --WIyZ46R2i8wDzkSu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2019-Dec-09 08:38:01 -0600, Kyle Evans wrote: =2E.. >> +static vm_offset_t >> +freebsd_parse_boot_param(struct arm64_bootparams *abp) >> +{ >> + vm_offset_t lastaddr =3D 0; >> + void *kmdp; >> +#ifdef DDB >> + vm_offset_t ksym_start; >> + vm_offset_t ksym_end; >> +#endif >> + >> + if (abp->modulep =3D=3D 0) >> + return (0); >> + >> + preload_metadata =3D (caddr_t)(uintptr_t)(abp->modulep); >> + kmdp =3D preload_search_by_type("elf kernel"); >> + if (kmdp =3D=3D NULL) >> + return (0); >> + >> + boothowto =3D MD_FETCH(kmdp, MODINFOMD_HOWTO, int); >> + loader_envp =3D MD_FETCH(kmdp, MODINFOMD_ENVP, char *); >> + init_static_kenv(static_kenv, 0); > >This should read "loader_envp" instead of "static_kenv" -- as written, >it stomps over the kenv provided by loader. Which breaks diskless booting and NFS root. Changing static_kenv to loader_envp unbreaks the kernel. --=20 Peter Jeremy --WIyZ46R2i8wDzkSu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE7rKYbDBnHnTmXCJ+FqWXoOSiCzQFAl3vVvJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVF QjI5ODZDMzA2NzFFNzRFNjVDMjI3RTE2QTU5N0EwRTRBMjBCMzQACgkQFqWXoOSi CzRSPA/8Czk5dO7sN067HIULDFqg5oG0zHWw+aLh2tybNu6YYWBaBNTGDlbF2+J+ u7VzTNry9HZmunHKsWG8Ui7DYP2vSdvcZTj/QGo7KO1Q8mds5J4dEOSpZbcIENAi 1jF56XHjBwpG9UKudGqtb6BcAUWI4tvwhXe3xVttwgWdF4Xj65WFWjAe4N8147er 3IIZJA4dBfcy88/qvVza100ktj8Gs89nV1AkX6UXJPu4U7PI6zZ62yXBA7ND+7nx Xolnd0d3JNsD/MKqtjbn7ogwVHnY4nahua8A8yUoqo9Nl5borKgWRIP1S9c2MTuW kCE8tchsa813+vsF4+Bb97uLd8leVA9HBvllVCG1ysLzJ0amc7R98F2EGEM1R2Lk UwPOBgCa0xge5L/SMxZJQA6PGT+hlf85Cpg7Edi9T9Jd/G5kh3QTWNt3s7aC+fXG BOvgEUwqLkZC16TZracrsOztpTgRwnH9e7SILI2uq1kCn8bbwjfKdVUmi0ROZ35B E9UorbE6U9pKteOUNkBgaeeelcWEN/SB55aS0w0oRqDEBD2kS21E/YepumPVUG0F 62KJwVewk3d3k9j6twYWEalD5vVJ1dRBmoPnswfnQLOWQ45wd0CW2tc6cbo8ycex W6LfeMeX1cT4cdM/kBHSliomX4YpBI2tggkfgaa0IOiECErUqzU= =vlyy -----END PGP SIGNATURE----- --WIyZ46R2i8wDzkSu--