From owner-freebsd-arch  Thu Feb 21 21:39:40 2002
Delivered-To: freebsd-arch@freebsd.org
Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3965637B400; Thu, 21 Feb 2002 21:39:39 -0800 (PST)
Received: (from dillon@localhost)
	by apollo.backplane.com (8.11.6/8.9.1) id g1M5ddM13773;
	Thu, 21 Feb 2002 21:39:39 -0800 (PST)
	(envelope-from dillon)
Date: Thu, 21 Feb 2002 21:39:39 -0800 (PST)
From: Matthew Dillon <dillon@apollo.backplane.com>
Message-Id: <200202220539.g1M5ddM13773@apollo.backplane.com>
To: John Baldwin <jhb@FreeBSD.org>
Cc: arch@FreeBSD.org, Julian Elischer <julian@elischer.org>
Subject: Re: RE: that INVARIANT/ucred freeing stuff.
References:  <XFMail.020221233659.jhb@FreeBSD.org>
Sender: owner-freebsd-arch@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-arch.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-arch>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-arch>
X-Loop: FreeBSD.ORG

:Fine, stick it under DIAGNOSTIC (which isn't dead.)  The problem is that there
:aren't just 5 places in the kernel that you would need to stick this assert,
:you would need it all over the place.  But I guess no one else has looked at
:all the places that p_ucred is used and thought about how to ensure we don't
:use a bogus td_ucred.
:
:
:John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/

    Don't try to overengineer the problem.  Unless you believe there is
    a serious problem, there is no need to put a check in every single
    conceivable place an error might occur.  Just putting a few safety checks
    in a few critical places should be sufficient.

					-Matt
					Matthew Dillon 
					<dillon@backplane.com>

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message