From owner-freebsd-current@FreeBSD.ORG Mon Mar 17 05:12:15 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 646C71065670 for ; Mon, 17 Mar 2008 05:12:15 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.229]) by mx1.freebsd.org (Postfix) with ESMTP id 1E1C88FC14 for ; Mon, 17 Mar 2008 05:12:14 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by wx-out-0506.google.com with SMTP id i29so5701390wxd.7 for ; Sun, 16 Mar 2008 22:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; bh=542C+u8BBVmJ2nKHNP8UU4RAXCaemphjCj0Ta7fPn60=; b=UNe3vd9poX9ecf84RUMsGvTi942OXC89Vu9lghUOPk4kzWuUP5nfAUQifIJVuPfbajjlQRse75biIaPK0VYK0YsQL1qguVkB7x0u/ehCj2XYBXTexXzyZeMaSEYjNzDVZTPLd98cbMJblWnkl5crAJ33D07vc2c/CVgVK2ugDPA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=JRAHpxenw07AOpxKErMn/0BVfbE+gw7KfSQ5a5NeqX/+gSfQI7CkzE9eOZBqYQegmHyhTKAxLuqkiiaB03LTIJX98YYy7uKLmgzOwN2MicA122ie21dxuqDCLTU5U6TCcsCWTSjWrJKVcEesG1j9eSSMiMC2FXwo0U1a5UnuGNk= Received: by 10.100.4.1 with SMTP id 1mr31458009and.81.1205730733955; Sun, 16 Mar 2008 22:12:13 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.google.com with ESMTPS id 3sm30878056wrs.22.2008.03.16.22.12.09 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 16 Mar 2008 22:12:12 -0700 (PDT) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id m2H5C58E002693 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 17 Mar 2008 14:12:05 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id m2H5C3Fi002692; Mon, 17 Mar 2008 14:12:03 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Mon, 17 Mar 2008 14:12:03 +0900 From: Pyun YongHyeon To: Ian FREISLICH Message-ID: <20080317051203.GC2503@cdnetworks.co.kr> References: <20080222042700.GB30497@cdnetworks.co.kr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Cc: FreeBSD Current , Robert Backhaus Subject: Re: Packet corruption in re0 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Mar 2008 05:12:15 -0000 On Fri, Feb 22, 2008 at 10:43:22AM +0200, Ian FREISLICH wrote: > Pyun YongHyeon wrote: > > On Thu, Feb 21, 2008 at 01:18:18PM +0200, Ian FREISLICH wrote: > > > Pyun YongHyeon wrote: > > > > On Thu, Feb 21, 2008 at 02:47:43PM +1000, Robert Backhaus wrote: > > > > > On Thu, Feb 21, 2008 at 1:50 PM, Pyun YongHyeon wr > ote: > > > > > > On Thu, Feb 21, 2008 at 11:03:02AM +1000, Robert Backhaus wrote: > > > > > > > I am experiencing roughly 15% packet corruption on the re inter > face > > > on > > > > > > > my freebsd 7/amd64 box. > > > > > > > > > > > > > > FreeBSD gw.flexi.robbak.com 7.0-PRERELEASE FreeBSD 7.0-PRERELEA > SE #8 > > > : > > > > > > > Tue Feb 5 09:49:55 EST 2008 > > > > > > > root@gw.flexi.robbak.com:/usr/obj/usr/src/sys/GW amd64 > > > > > > > > > > > > > > Just to make troubleshooting difficult, this problem only shows > up > > > > > > > after the system has been up for roughly 36 hours, depending on > the > > > > > > > amount of traffic. > > > > > > > > > > > > > > > > > > > I didn't take a look attached tcpdump files but I guess the > > > > > > instability issue was fixed in HEAD. It's not yet MFCed but > > > > > > I'll handle it in a week. > > > > > > > > > > > > Would you try re(4) in HEAD? > > > > > > > > > > > > > > > > OK, I'll do that. What is the best way to do that? csupping to "." se > ems a > > > > > bit drastic, and I don't do much with cvs proper. I take it that I sh > ould > > > use > > > > > anon-cvs to grab the directory, but I don't quite know how. > > > > > > > > > > > > > Copy sys/dev/re/if_re.c, sys/pci/if_rlreg.h in HEAD to your box. > > > > Due to lack of m_defrag(9) in 7-PRERELEASE/RC, you also have to add > > > > that function to if_re.c(Copy m_defrag() in sys/kern/uipc_mbuf.c on > > > > HEAD/RELENG_7 to if_re.c). That would make it build on your box. > > > > > > This doesn't solve the problem that I'm seeing on re(4) interfaces. > > > It basically shows up as quagga establishing OSPF neighours as > > > "Exchange/DR" when VLAN hardware tagging is enabled. I'm running > > > OSPF over 802.1Q vlans. Neighbours are correctly negotiated once > > > VLAN hardware tagging is disabled on the interface. > > > > > > I'll do more debugging. > > > > > > > Hmm. That sounds like different issue to me. I guess I din't change > > any semantics in VLAN H/W tagging. Do you still the same VLAN H/W > > tagging related issues on RELENG_7? > > > > To narrow down the issue it would be even better to know which parts > > of H/W assistance was broken. For example, > > - Disable checksum offload for VLAN interface first and check > > whether quagga works. > > You can only disable offload on the parent interface. > > > - Disable checksum offload for parent interface and check again. > > If you can post tcpdump output for broken conntection it may help a > > lot to diagnose the issue. > > The only flag affecting this behaviour is vlanhwtag. Various > permutations of the interface flags make no difference to this > behaviour as long as hardware tagging is enabled. > > It seems like it's corrupting large packets on transmit when vlanhwtag > is enabled. From the tcpdump output it looks like a padding or > packet length issue. > > Here's what tcpdump on the re(4) device thinks it's transmitting: > > 00:08:a1:3c:32:9c > 00:90:fb:0c:89:7d, ethertype 802.1Q (0x8100), length 1510: vlan 1000, p 0, ethertype IPv4, 196.22.138.92 > 196.22.138.89: OSPFv2, Database Description, length: 1472 > > Here's what was actually recieved by the em(4) device on the > neighbour. Note the absense of the 801.1Q header: > > 00:08:a1:3c:32:9c > 00:90:fb:0c:89:7d, ethertype IPv4 (0x0800), length 1506: 196.22.138.92 > 196.22.138.89: OSPFv2, Database Description, length: 1472 > > When vlanhwtagging is disabled, the re(4) device transmits: > > 00:90:fb:0c:89:7d > 00:08:a1:3c:32:9c, ethertype 802.1Q (0x8100), length 1510: vlan 1000, p 0, ethertype IPv4, 196.22.138.89 > 196.22.138.92: OSPFv2, Database Description, length: 1472 > > and the em(4) device recieves: > > 00:08:a1:3c:32:9c > 00:90:fb:0c:89:7d, ethertype 802.1Q (0x8100), length 1510: vlan 1000, p 0, ethertype IPv4, 196.22.138.92 > 196.22.138.89: OSPFv2, Database Description, length: 1472 > > Let me know if you need more detailed tcpdump output than I've provided. > I guess I've found a VLAN hardware tagging bug in re(4). Please try this one and let me know the result. http://people.freebsd.org/~yongari/re/if_re.c http://people.freebsd.org/~yongari/re/if_rlreg.h > Ian > > -- > Ian Freislich > -- Regards, Pyun YongHyeon