From owner-freebsd-current@FreeBSD.ORG Wed Aug 5 14:41:57 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1B4561065674 for ; Wed, 5 Aug 2009 14:41:57 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-fx0-f224.google.com (mail-fx0-f224.google.com [209.85.220.224]) by mx1.freebsd.org (Postfix) with ESMTP id 9CFB08FC08 for ; Wed, 5 Aug 2009 14:41:56 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: by fxm24 with SMTP id 24so139784fxm.36 for ; Wed, 05 Aug 2009 07:41:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=TGud46n7BvIvFP/Zsq8hLeIzZb9tgdpvlWshK0DH10U=; b=wt1B/vTim7SbKDFmIRAM+snFMk1r19T6mK6xnlU0m/mCoq4OvlclxqbYGpDOx/ZMzB s5otJf0ro9DrHq+24tMS134OXNttUMWMJsEunQjGQKpYXMPd4abl7NcFJ83XTCCSPYqJ 2dSs/8D0tGPtE3L726Wy+2UTBvsQ+m3OGMnoM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=DwqpJfXti8j9uWuOUsbCLzAAiyElTJBeYE0UnPPm58KX8wELrD4/G5yu1f08gAjSQ9 F2ARNbQpfVUlldFZ5pYbSz1RbiT5jNbB842oASW0NzlnceM8xx0RZ2mJisUjICOJO2DX yfdU/lobFEVT3VUrZ07fTMFZduaIUr7iMG4OU= MIME-Version: 1.0 Sender: asmrookie@gmail.com Received: by 10.223.119.207 with SMTP id a15mr3651155far.11.1249481611067; Wed, 05 Aug 2009 07:13:31 -0700 (PDT) In-Reply-To: <200908051603.35169.hselasky@c2i.net> References: <90a5caac0908050258w1ea85736sac0b66ae5998e7de@mail.gmail.com> <20090805111247.GA1292@hoeg.nl> <200908051603.35169.hselasky@c2i.net> Date: Wed, 5 Aug 2009 16:13:31 +0200 X-Google-Sender-Auth: 6df71650e0716a32 Message-ID: <3bbf2fe10908050713r79066277hd8822161b78222f@mail.gmail.com> From: Attilio Rao To: Hans Petter Selasky Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Ed Schouten , freebsd-current@freebsd.org, Robert Watson , FreeBSD Current , Lucius Windschuh Subject: Re: uaudio attach panic: Giant not locked X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Aug 2009 14:41:57 -0000 2009/8/5 Hans Petter Selasky : > On Wednesday 05 August 2009 13:43:11 Robert Watson wrote: >> On Wed, 5 Aug 2009, Ed Schouten wrote: >> > * Lucius Windschuh wrote: >> >> So I updated my machine to CURRENT r196062 and use a USB audio >> >> converter. Attaching it to the machine leads to a kernel panic: >> >> >> >> >> > >> > I suspect this has something to do with the Newbus locking, which causes >> > some pieces of code to run without Giant held, while they previously did. >> >> There's a patch in the re@ queue to re-add Giant around newbus attachment, >> per John Baldwin's request. However, committing that patch is stalled >> while issues with the svn->cvs export of the new RELENG_8 branch are >> resolved. I expect to see the patch go into the tree RSN. >> > > Try this patch: > > http://perforce.freebsd.org/chv.cgi?CH=167030 Hans, I recall of a similar problem in ukbd. I resolved it by acquiring Giant earlier in ukbd_attach(), but probabilly I could just bring it down and pass a NULL pointer to usbd_do_transfer(), right? Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein