From nobody Mon Apr 11 18:10:08 2022 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 6414C11CD1BD for ; Mon, 11 Apr 2022 18:12:16 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KccQ737zbz4wwx; Mon, 11 Apr 2022 18:12:15 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: by mail-qk1-f169.google.com with SMTP id 141so1832884qkf.3; Mon, 11 Apr 2022 11:12:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=nyklKY+fXKVv304ooXfogWDBZBnBgOnuJ6d+bfklTuc=; b=Urz6Z7cQcYpUkQMM1/kJmr4yzi+Xu1dE0HendQGsl4Txee0UsZKdiL4ppgX+SdNarQ YXKxbwL82ujGOxd+v0I34AfM6GEfdBx3dGEKa6T9NbxCQrv8964WU3gw3cedmwuAHnj7 rOlp8IyTIBn0HqZz9vaHC+c0rqGOjYJlRqX2jxTl1RH2NLhr7fB3EgVoo6AfFZNMH3VF 4CYTRIaR5bYZTocw8JvXwnmtRbgHneECtMmIusgtsoHrcPcRiC5RCnoX9jOh+g5fKjHy X3u9YP/ZBEUkvtcuJIHOFnWCI3QScmSD+jXU72z6qK+A3Zml1OJqONEb9RZBuVt0AwqW DggA== X-Gm-Message-State: AOAM532k5gMrHZFf/S8VEYWCAQFVrT8ElHETO933Hc05TptBz4r4fFn1 h5O8LlxXa9F6qk5Cr5n1KNLX26407KsrSz2EFww= X-Google-Smtp-Source: ABdhPJxUTzO2cOQoJMTgZj2zccII8kNIbj4EWx+Qhg3ilWw6le1IiaDHXPcBVaUW+6new/h7WyoLIw== X-Received: by 2002:a05:620a:2449:b0:69a:4ae:85e5 with SMTP id h9-20020a05620a244900b0069a04ae85e5mr506777qkn.30.1649700728644; Mon, 11 Apr 2022 11:12:08 -0700 (PDT) Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com. [209.85.128.177]) by smtp.gmail.com with ESMTPSA id h12-20020a05622a170c00b002efa6a81386sm1046037qtk.91.2022.04.11.11.12.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Apr 2022 11:12:08 -0700 (PDT) Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-2ed65e63afcso15829707b3.9; Mon, 11 Apr 2022 11:12:08 -0700 (PDT) X-Received: by 2002:a81:5b56:0:b0:2ec:34e7:9b5c with SMTP id p83-20020a815b56000000b002ec34e79b5cmr4106622ywb.300.1649700727972; Mon, 11 Apr 2022 11:12:07 -0700 (PDT) List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 References: <168EF37D-8591-4F8C-93E1-F15FDA10F311@FreeBSD.org> <9ZQ1RgjxwamYo_YNKUEfd5Aq7X9m6pUgRdbyxcj71_qRzdufKX8g9V-Xe8jsCn8b6Uo3jvVA3IwtJeYm7N4A6i35MqBI5PrVBuf_rKxjd60=@insane.engineer> In-Reply-To: <9ZQ1RgjxwamYo_YNKUEfd5Aq7X9m6pUgRdbyxcj71_qRzdufKX8g9V-Xe8jsCn8b6Uo3jvVA3IwtJeYm7N4A6i35MqBI5PrVBuf_rKxjd60=@insane.engineer> From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Date: Mon, 11 Apr 2022 20:10:08 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Build issue with i386 port To: jbo@insane.engineer Cc: Dimitry Andric , "ports@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4KccQ737zbz4wwx X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of fernandoapesteguia@gmail.com designates 209.85.222.169 as permitted sender) smtp.mailfrom=fernandoapesteguia@gmail.com X-Spamd-Result: default: False [-0.33 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; RCVD_COUNT_THREE(0.00)[4]; NEURAL_HAM_SHORT(-1.00)[-0.998]; FORGED_SENDER(0.30)[fernape@freebsd.org,fernandoapesteguia@gmail.com]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FROM_NEQ_ENVFROM(0.00)[fernape@freebsd.org,fernandoapesteguia@gmail.com]; R_MIXED_CHARSET(0.62)[subject]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.96)[-0.961]; TAGGED_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_LONG(1.00)[1.000]; RCVD_IN_DNSWL_NONE(0.00)[209.85.222.169:from,209.85.128.177:received]; MLMMJ_DEST(0.00)[ports]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.222.169:from]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Mon, Apr 11, 2022 at 8:04 PM wrote: > > Oooh! This is so obvious it almost hurts... > So basically what happened is that upstream's v1.00 release that the port= is building didn't yet support i386. Meanwhile, I was able to compile > successfully on my VMs because I was using the main/master branch which d= oes support i386. > I hope we can just consider this a beginner's mistake :p > > This brings me to the next question: According to Repology [1], a lot of = packages are using the v1.01 tag whereas our port is currently > using v1.00. The reason I didn't update the port yet is because there isn= 't an official release on the upstream's GitHub page. > What is the recommended/preferred way of handling this? I would cherry pick the patch with PATCHFILES: https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-distfiles +PATCH_SITES=3D https://github.com/Dr-Noob/cpufetch/commit/ +PATCHFILES=3D 0db9f1f5c26e57a6383f4609c5605ed5d3d41fd1.patch:-p1 I already have the change ready to push it. Shall we? > > [1] https://repology.org/project/cpufetch/versions > > > Best regards, > ~ Joel > > > > ------- Original Message ------- > On Monday, April 11th, 2022 at 19:57, Dimitry Andric wr= ote: > > > > > > > > On 11 Apr 2022, at 19:53, Fernando Apestegu=C3=ADa fernape@freebsd.org = wrote: > > > > > On Mon, Apr 11, 2022 at 7:24 PM jbo@insane.engineer wrote: > > > > ... > > > > > > gmake[1]: Entering directory '/wrkdirs/usr/ports/sysutils/cpufetch/= work/cpufetch-1.00' > > > > Makefile:38: Unsupported arch detected: i386. See https://github.co= m/Dr-Noob/cpufetch#1-support > > > > Makefile:39: If your architecture is supported but the compilation = fails, please open an issue in https://github.com/Dr-Noob/cpufetch/issues > > > > Makefile:40: *** Aborting compilation. Stop. > > > > gmake[1]: Leaving directory '/wrkdirs/usr/ports/sysutils/cpufetch/w= ork/cpufetch-1.00' > > > > =3D=3D=3D> Compilation failed unexpectedly. > > > > Try to set MAKE_JOBS_UNSAFE=3Dyes and rebuild before reporting the = failure to > > > > the maintainer. > > > > *** Error code 1 > > > > > > > > Upstream's Makefile uses $(shell uname -m) to determine the archite= cture [2]. My VMs are successfully reporting this as > > > > i386 which upstream's Makefile appears to support explicitly. After= all, I'm also able to build this software > > > > on those VMs if just cloning & running gmake manually. > > > > > > > > I'm not really sure where to go from here. As I can build the softw= are in FreeBSD i386 VMs I think > > > > that the issue is related to my port and not upstream. But then aga= in, the build fails "within" upstream's Makefile. > > > > > > > > Could somebody help me out here? > > > > > > When the Makefile checks the output of uname -m, it compares the > > > result with a list of values that includes i686 but not i386. > > > I think a simple REINPLACE_CMD would suffice here. > > > > > > Since I failed to detect this, do you want me to fix it in the repo? = I > > > will also send a patch upstream. > > > > > > No need :) > > https://github.com/Dr-Noob/cpufetch/commit/0db9f1f5c26e57a6383f4609c560= 5ed5d3d41fd1 > > > > -Dimitry