From owner-freebsd-stable@freebsd.org Mon Mar 14 14:04:52 2016 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F1C63AD0702 for ; Mon, 14 Mar 2016 14:04:52 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from erouter6.ore.mailhop.org (erouter6.ore.mailhop.org [54.187.213.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B9CB1379 for ; Mon, 14 Mar 2016 14:04:52 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: 2acdc146-e9ed-11e5-a023-11ad6df26ed1 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.34.117.227 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.34.117.227]) by outbound3.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Mon, 14 Mar 2016 14:00:53 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.14.9) with ESMTP id u2EE4miw020709; Mon, 14 Mar 2016 08:04:50 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1457964288.9986.3.camel@freebsd.org> Subject: Re: releng/10.3 rc netwait disabled by ipfw dependency From: Ian Lepore To: John Marshall , freebsd-stable@FreeBSD.org Date: Mon, 14 Mar 2016 08:04:48 -0600 In-Reply-To: <20160312054618.GA6373@rwpc16.gfn.riverwillow.net.au> References: <20160312054618.GA6373@rwpc16.gfn.riverwillow.net.au> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.16.5 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Mar 2016 14:04:53 -0000 On Sat, 2016-03-12 at 16:46 +1100, John Marshall wrote: > I recently upgraded a server from 10.2-RELEASE to 10.3-RC2. The > server > has ipfw configured and also has netwait enabled in rc.conf. All was > good in 10.2-RELEASE. > > Now, rc pauses during netwait for the full ${netwait_timeout} failing > to > ping ${netwait_ip}, prints a WARNING about the network likely not > being > properly up, then proceeds to enable the firewall and start other > components with varying degrees of success (now that the interfaces > can > pass packets and has started configuring itself - think IPv6 SLAAC). > The netwait rc script used to "REQUIRE: NETWORKING", until r294680 > when > (among other things) this happened... > > # PROVIDE: netwait > -# REQUIRE: NETWORKING > +# REQUIRE: devd routing > # KEYWORD: nojail > > Adding ipfw to the netwait REQUIRE list makes things work for me (see > Bug 207916) but I am sure there is more that ought to be taken into > account and perhaps the dependency ought to be resolved in a > different > way. > Just a quick followup for the archives, this was turned into PR 207916 and a workaround was committed as r296807. A better fix, I think, would be to separate waiting for the network interfaces to appear from waiting for network connectivity to be functional (ping test), but I ran into some circular-dependency problems, so I committed a "good enough for now" workaround. -- Ian