From owner-cvs-all@FreeBSD.ORG  Mon Dec 13 00:14:09 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D0EEE16A4D0
	for <cvs-all@freebsd.org>; Mon, 13 Dec 2004 00:14:09 +0000 (GMT)
Received: from pimout2-ext.prodigy.net (pimout2-ext.prodigy.net
	[207.115.63.101])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3D2A443D1D
	for <cvs-all@freebsd.org>; Mon, 13 Dec 2004 00:14:09 +0000 (GMT)
	(envelope-from julian@elischer.org)
Received: from [192.168.1.102] (adsl-216-100-134-143.dsl.snfc21.pacbell.net
	[216.100.134.143])iBD0DsGr335858;	Sun, 12 Dec 2004 19:13:54 -0500
Message-ID: <41BCDEC1.4000009@elischer.org>
Date: Sun, 12 Dec 2004 16:13:53 -0800
From: Julian Elischer <julian@elischer.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.8a3) Gecko/20041017
X-Accept-Language: en, hu
MIME-Version: 1.0
To: Scott Mitchell <scott+freebsd@fishballoon.org>
References: <20041212133752.GE68019@tuatara.fishballoon.org>
	<200412121411.aa89799@salmon.maths.tcd.ie>
	<20041212142640.GF68019@tuatara.fishballoon.org>
In-Reply-To: <20041212142640.GF68019@tuatara.fishballoon.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
cc: src-committers@freebsd.org
cc: cvs-src@freebsd.org
cc: Scott Long <scottl@freebsd.org>
cc: cvs-all@freebsd.org
cc: Ian Dowse <iedowse@maths.tcd.ie>
cc: Ceri Davies <ceri@submonkey.net>
cc: Julian Elischer <julian@freebsd.org>
Subject: Re: cvs commit: src/sys/sys mouse.h src/sys/dev/usb ums.c usbhid.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Dec 2004 00:14:09 -0000

Scott Mitchell wrote:
> On Sun, Dec 12, 2004 at 02:11:22PM +0000, Ian Dowse wrote:
> 
>>In message <20041212133752.GE68019@tuatara.fishballoon.org>, Scott Mitchell wri
>>tes:
>>
>>>On Sun, Dec 12, 2004 at 12:23:05PM +0000, Ceri Davies wrote:
>>>
>>>>On Sat, Dec 11, 2004 at 10:39:10PM -0700, Scott Long wrote:
>>>>
>>>>>Julian Elischer wrote:
>>>>>
>>>>>> Add support for USB Microsoft Intellimouse
>>>>>> 
>>>>>> PR:             kern/70607
>>>>>> Submitted by:   Matt Wright <matt@consultmatt.co.uk>
>>>>>> MFC after:      1 week
>>>>>
>>>>>What 'support' does this add?
>>>>
>>>>They have another axis on the wheel: you can tilt it from left to right.
>>>>
>>>>Ceri
>>>
>>>Apart from that, the device in question (wireless Intellimouse 2.0) didn't
>>>work as any kind of mouse without this patch.
>>>
>>>	Scott
>>
>>As pointed out in the PR though, it doesn't seem necessary to change
>>struct mousestatus and the MOUSE_GETSTATUS ioctl API just to make
>>the device work. All other mouse drivers in the tree will need to
>>be updated to initialise the new `dt' field. There's also one part
>>of the patch that looks as if it could easily break other devices:
> 
> 
> Ahhh, my bad.  I'd read the PR and thought it was the last version
> mentioned by marko@ (without the mousestatus change) that had been
> committed.  Although now that I look a bit closer I can't actually find
> that version anywhere.
> 
> I'll shut up now.
> 
> 	Scott
> 

uh my bad.. I THOUGHT I had committed the last version, as I got it from
the URL he supplied as being the last one..
I'll look around to see if there is a newer one, or try fix this one..