From owner-svn-src-all@FreeBSD.ORG  Mon Aug  6 12:14:06 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6DCE81065679;
	Mon,  6 Aug 2012 12:14:06 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
	[IPv6:2001:470:1f10:75::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 3E0378FC15;
	Mon,  6 Aug 2012 12:14:06 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id 91AB7B968;
	Mon,  6 Aug 2012 08:14:05 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: "Andrey V. Elsukov" <ae@freebsd.org>
Date: Mon, 6 Aug 2012 08:07:49 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p17; KDE/4.5.5; amd64; ; )
References: <201208051437.q75EbnJO093363@svn.freebsd.org>
In-Reply-To: <201208051437.q75EbnJO093363@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201208060807.49114.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
	(bigwig.baldwin.cx); Mon, 06 Aug 2012 08:14:05 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r239066 - head/sys/boot/i386/libi386
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Aug 2012 12:14:06 -0000

On Sunday, August 05, 2012 10:37:49 am Andrey V. Elsukov wrote:
> Author: ae
> Date: Sun Aug  5 14:37:48 2012
> New Revision: 239066
> URL: http://svn.freebsd.org/changeset/base/239066
> 
> Log:
>   Add offset field to the i386_devdesc structure to be compatible with
>   disk_devdesc structure. Update biosdisk driver to the new disk API.
> 
> Modified:
>   head/sys/boot/i386/libi386/Makefile
>   head/sys/boot/i386/libi386/biosdisk.c
>   head/sys/boot/i386/libi386/devicename.c
>   head/sys/boot/i386/libi386/libi386.h
> 
> Modified: head/sys/boot/i386/libi386/biosdisk.c
> 
==============================================================================
> --- head/sys/boot/i386/libi386/biosdisk.c	Sun Aug  5 14:11:42 2012	
(r239065)
> +++ head/sys/boot/i386/libi386/biosdisk.c	Sun Aug  5 14:37:48 2012	
(r239066)
>  
>  struct devsw biosdisk = {
> -    "disk", 
> -    DEVT_DISK, 
> -    bd_init,
> -    bd_strategy, 
> -    bd_open, 
> -    bd_close, 
> -    noioctl,
> -    bd_print,
> -    NULL
> +	"disk",
> +	DEVT_DISK,
> +	bd_init,
> +	bd_strategy,
> +	bd_open,
> +	bd_close,
> +	bd_ioctl,
> +	bd_print,
> +	NULL
>  };

You should not have mixed style changes in with code changes.  This makes the 
diff far harder to review and destroys history.  I asked you to not do this 
before.  *sigh*

-- 
John Baldwin