Date: Thu, 14 Oct 2021 13:45:15 +0000 From: "Sergey A. Osokin" <osa@freebsd.org> To: Henry Hu <henry.hu.sh@gmail.com> Cc: Po-Chuan Hsieh <sunpoet@freebsd.org>, Dima Panov <fluffy@freebsd.org>, Alexey Dokuchaev <danfe@freebsd.org>, Li-Wen Hsu <lwhsu@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, ports-committers@freebsd.org Subject: Re: git: 2bc3e6229feb - main - net-im/telegram-desktop: Update to 3.1.9 Message-ID: <YWg0a6O14tYdgT4a@FreeBSD.org> In-Reply-To: <CAEJt7ha85g%2BAkA76FrA729GFjHf3xD%2BHSEk5mbb8sSdvY6eqTA@mail.gmail.com> References: <202110121357.19CDvdWN002446@gitrepo.freebsd.org> <YWWcR20bUeZJ1I4y@FreeBSD.org> <YWcURc7PrcJA65jY@FreeBSD.org> <09c5ed72-fded-4282-b49f-6d494dff88b8@Canary> <CAMHz58Q57VrqC3kWgH-Z26OvkAYsBzsiZq5nJr2xkiPAx60-ow@mail.gmail.com> <CAEJt7ha85g%2BAkA76FrA729GFjHf3xD%2BHSEk5mbb8sSdvY6eqTA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Cmhh4rhQyOH6Lzof Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Henry, On Wed, Oct 13, 2021 at 09:00:56PM -0400, Henry Hu wrote: > On Wed, Oct 13, 2021 at 2:19 PM Po-Chuan Hsieh <sunpoet@freebsd.org> wrot= e: > > On Thu, Oct 14, 2021 at 1:31 AM Dima Panov <fluffy@freebsd.org> wrote: > > > > > Moin! > > > > > > Have tested the almost same patch. > > > Small suggestions: > > > > > > GTK_USE=3D GNOME=3Dcairo gtk30 > > > > Do you mean "GTK_USE=3D GNOME=3Dcairo,gtk30" (use comma instead of spac= e)? >=20 > Why do we need to add cairo? >=20 > > GTK_DESC=3D WebKit-gtk integration > > > > > > On Wednesday, Oct 13, 2021 at 8:15 PM, Sergey A. Osokin <osa@freebsd.= org > > > > > > wrote: > > > Well, I'm not totally sure is my approach is corrent, but here's the > > > patch returning back GTK staff. Please be aware: it wasn't tested yet. > > >=20 > Thanks for your patch! May I suggest naming the new option "WEBKITGTK", > because the main point of the option is to use webkit-gtk? Sure. May I use this as your approval to commit these changes? -- Sergey Osokin --Cmhh4rhQyOH6Lzof Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAEBCgB9FiEEZTMJYdHlAQrZCsSmOBlAga+KbzQFAmFoNGdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDY1 MzMwOTYxRDFFNTAxMEFEOTBBQzRBNjM4MTk0MDgxQUY4QTZGMzQACgkQOBlAga+K bzRQeAv+NVnI6+/j5SusT2YS0OAMEqNi6EUMUZ5IgP/d0oAiDVhB5P6iyGGhSnll IZtkYtyJjRaQX/PozlzxypB1kVT0RbaYu9071fHdqxSef//K9hQ7PHEe14jeLnfD SS4bmWp7cV/UEd7MGDsN3MNDf5nOjBT5v2J9ZFCrJAJ+peLN9aq4UqAqOd+E328b Act9q/teyKZKybzGUpwk21H8Wjqc1hnlNguLTpAhpB36baIhLcf9qnUP0qmEwVXH GCD7p0vshAoPUKjwshCM50xK+c8uc5RPYGQVLMjdVSmPJgVgw2waVdMA9FacnKZ8 ftYjBdaKOAdmD1OMwmVDlW2L67myVfknF2sBffmxqhnFdjTxjnGLugYRbJr0o+BY 14DLDG7Qs6qVWLURp7p53HDNAWmYgPGifRG1f8fMVppif1mGLvdanrdSKBWgJE2m hJUG8bfRmc9SFgbG1yEH6QTnUq2znUm8TxBBBMJPclj/3gBG9gBksGJ/JnUvzwhi LQGSh/Uh =Ki65 -----END PGP SIGNATURE----- --Cmhh4rhQyOH6Lzof--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YWg0a6O14tYdgT4a>