From owner-freebsd-bugs@FreeBSD.ORG Sun Nov 11 19:50:06 2007 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5B41B16A419 for ; Sun, 11 Nov 2007 19:50:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 5079913C4B2 for ; Sun, 11 Nov 2007 19:50:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id lABJo6V3039711 for ; Sun, 11 Nov 2007 19:50:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id lABJo6WV039710; Sun, 11 Nov 2007 19:50:06 GMT (envelope-from gnats) Date: Sun, 11 Nov 2007 19:50:06 GMT Message-Id: <200711111950.lABJo6WV039710@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Remko Lodder Cc: Subject: Re: conf/117984: [patch] map improvement for etc/mail/Makefile X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Remko Lodder List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Nov 2007 19:50:06 -0000 The following reply was made to PR conf/117984; it has been noted by GNATS. From: Remko Lodder To: Helge Oldach Cc: FreeBSD-gnats-submit@FreeBSD.org, Gregory Shapiro Subject: Re: conf/117984: [patch] map improvement for etc/mail/Makefile Date: Sun, 11 Nov 2007 20:45:59 +0100 Helge Oldach wrote: > Below is a suggested improvement for /etc/mail/Makefile. It implements > multiple input files for various maps, e.g. virtusertable, permitting > easier maintenance of map input files. The idea is that the map input > file (e.g. /etc/mail/virtusertable) may not only be a flat file (as it > is currently the case) but may also be a directory which contains a set > of files that comprise the map sources. > > For example consider that the three files > > /etc/mail/virtusertable/thisone.com > /etc/mail/virtusertable/another.com > /etc/mail/virtusertable/third.com > > contain virtusertables specific to the domains thisone.com, another.com, > and third.com. They now can be independently maintained, alleviating the > need to maintain a single, potentially large map source file. > > The rather trivial patch below implements this, and also maintains > backward behaviour. (Note that /dev/null for the cat(1) command is > necessary; it catches the case of an empty directory.) I think this describes edge cases which are not suitable for the default installation, but that is just my opinion. If people want to go outside of that scope, they can surely do that, on their on free-will and they might be able to use the patch you submitted with the ticket, but I honestly think this should not be part of the base install. Thanks for using FreeBSD though and your willingness to consider this! I for one really appreciate this! Lets see what others think about this :) (because this is my opinion and others might think differently). Cheers remko -- Kind regards, Remko Lodder ** remko@elvandar.org FreeBSD ** remko@FreeBSD.org /* Quis custodiet ipsos custodes */