From owner-freebsd-testing@FreeBSD.ORG Fri Mar 14 07:53:56 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4E2F96D0 for ; Fri, 14 Mar 2014 07:53:56 +0000 (UTC) Received: from mail-qa0-f53.google.com (mail-qa0-f53.google.com [209.85.216.53]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 0B557F9C for ; Fri, 14 Mar 2014 07:53:55 +0000 (UTC) Received: by mail-qa0-f53.google.com with SMTP id w8so2137417qac.40 for ; Fri, 14 Mar 2014 00:53:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=zbS3YcMM3tx6dPPJVIr7yMnp4HeEZTpzA6XS/nvBBI4=; b=iGJ0hKGb1bvjPok5m7vW97e63TPi8lNgVIyQYkL4+iIJk02k5szd71FdT0O1xViOIQ g89kVUpaqFnNuInOGOX/FYFIS8XQb9Ax0VMGRDwBqaEGdDZcCM/puXnLxpgJQYVbt8tF GgxoHNULHXOTusrFQ/HVEqbYlTleqXjTultagWDmlUtgkLcN3gC8TrzCzpcb7bZd9aAs MrZDa3kotDUGtucioB9gxanY7au4qPfHvL0+vBaWbtTiQNqzPgy40lCVCbl17W6X4yLA WhBAgzXljWml8b8e7PrcqLo01qh4Bhe56sA/WuPJf3tYJvIh8G0wizLxQLIS0bpNTaEr wwXQ== X-Gm-Message-State: ALoCoQmP1jgEj2UOKItGP6lcjiOoNXrAPnsGU7qZJ6UWVRj9Xj5b6nF1iCHQ3ItK22A5RYfDPseE X-Received: by 10.140.102.2 with SMTP id v2mr7607581qge.27.1394783629782; Fri, 14 Mar 2014 00:53:49 -0700 (PDT) MIME-Version: 1.0 Sender: jmmv@meroh.net Received: by 10.96.83.102 with HTTP; Fri, 14 Mar 2014 00:53:29 -0700 (PDT) X-Originating-IP: [180.42.49.96] In-Reply-To: <423AB61A-6099-40F1-8931-B5339FFAEB65@gmail.com> References: <423AB61A-6099-40F1-8931-B5339FFAEB65@gmail.com> From: Julio Merino Date: Fri, 14 Mar 2014 16:53:29 +0900 X-Google-Sender-Auth: PZ7z-HMMCAp6DmC5yeEpd1xnX0E Message-ID: Subject: Re: Where to put test cases for stuff in /etc? To: Garrett Cooper Content-Type: text/plain; charset=ISO-8859-1 Cc: "freebsd-testing@freebsd.org" , "asomers@gmail.com" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Mar 2014 07:53:56 -0000 On Fri, Mar 14, 2014 at 5:40 AM, Garrett Cooper wrote: > >> On Mar 13, 2014, at 13:23, asomers@gmail.com wrote: >> >> I occasionally make changes to /etc/rc.subr and /etc/rc.d/*. Where >> can I write ATF test cases for those files? Should I create >> etc/tests/rc.subr_test.sh and etc/rc.d/tests/routing_test.sh ? Tests for these would be awesome. > Putting it under tests/etc would be a better idea for now. The build system under etc/ is a bit of a mess... What's the problem with putting tests in etc/tests/ and what would it take to fix that?