From owner-svn-src-head@FreeBSD.ORG  Tue Apr 23 13:02:48 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id A79954C7;
 Tue, 23 Apr 2013 13:02:48 +0000 (UTC)
 (envelope-from eadler@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 by mx1.freebsd.org (Postfix) with ESMTP id 99B621049;
 Tue, 23 Apr 2013 13:02:48 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.6/8.14.6) with ESMTP id r3ND2mhi024855;
 Tue, 23 Apr 2013 13:02:48 GMT (envelope-from eadler@svn.freebsd.org)
Received: (from eadler@localhost)
 by svn.freebsd.org (8.14.6/8.14.5/Submit) id r3ND2mQV024854;
 Tue, 23 Apr 2013 13:02:48 GMT (envelope-from eadler@svn.freebsd.org)
Message-Id: <201304231302.r3ND2mQV024854@svn.freebsd.org>
From: Eitan Adler <eadler@FreeBSD.org>
Date: Tue, 23 Apr 2013 13:02:48 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r249797 - head/sys/dev/acpi_support
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Apr 2013 13:02:48 -0000

Author: eadler
Date: Tue Apr 23 13:02:48 2013
New Revision: 249797
URL: http://svnweb.freebsd.org/changeset/base/249797

Log:
  Remove tautological compare.
  
  PR:		kern/176712
  Submitted by:	Hiren Panchasara <hiren.panchasara@gmail.com>
  Approved by:	cperciva (mentor)

Modified:
  head/sys/dev/acpi_support/acpi_toshiba.c

Modified: head/sys/dev/acpi_support/acpi_toshiba.c
==============================================================================
--- head/sys/dev/acpi_support/acpi_toshiba.c	Tue Apr 23 10:48:14 2013	(r249796)
+++ head/sys/dev/acpi_support/acpi_toshiba.c	Tue Apr 23 13:02:48 2013	(r249797)
@@ -324,7 +324,7 @@ hci_force_fan(ACPI_HANDLE h, int op, UIN
 
 	ACPI_SERIAL_ASSERT(toshiba);
 	if (op == HCI_SET) {
-		if (*state < 0 || *state > 1)
+               if (*state > 1)
 			return (EINVAL);
 		*state <<= HCI_FAN_SHIFT;
 	}
@@ -368,7 +368,7 @@ hci_lcd_brightness(ACPI_HANDLE h, int op
 
 	ACPI_SERIAL_ASSERT(toshiba);
 	if (op == HCI_SET) {
-		if (*brightness < 0 || *brightness > HCI_LCD_BRIGHTNESS_MAX)
+               if (*brightness > HCI_LCD_BRIGHTNESS_MAX)
 			return (EINVAL);
 		*brightness <<= HCI_LCD_BRIGHTNESS_SHIFT;
 	}
@@ -384,7 +384,7 @@ hci_lcd_backlight(ACPI_HANDLE h, int op,
 
 	ACPI_SERIAL_ASSERT(toshiba);
 	if (op == HCI_SET) {
-		if (*backlight < 0 || *backlight > 1)
+               if (*backlight > 1)
 			return (EINVAL);
 	}
 	return (hci_call(h, op, HCI_REG_LCD_BACKLIGHT, backlight));
@@ -397,7 +397,7 @@ hci_cpu_speed(ACPI_HANDLE h, int op, UIN
 
 	ACPI_SERIAL_ASSERT(toshiba);
 	if (op == HCI_SET) {
-		if (*speed < 0 || *speed > HCI_CPU_SPEED_MAX)
+               if (*speed > HCI_CPU_SPEED_MAX)
 			return (EINVAL);
 		*speed <<= HCI_CPU_SPEED_SHIFT;
 	}