Date: Tue, 23 Apr 2013 13:02:48 +0000 (UTC) From: Eitan Adler <eadler@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r249797 - head/sys/dev/acpi_support Message-ID: <201304231302.r3ND2mQV024854@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: eadler Date: Tue Apr 23 13:02:48 2013 New Revision: 249797 URL: http://svnweb.freebsd.org/changeset/base/249797 Log: Remove tautological compare. PR: kern/176712 Submitted by: Hiren Panchasara <hiren.panchasara@gmail.com> Approved by: cperciva (mentor) Modified: head/sys/dev/acpi_support/acpi_toshiba.c Modified: head/sys/dev/acpi_support/acpi_toshiba.c ============================================================================== --- head/sys/dev/acpi_support/acpi_toshiba.c Tue Apr 23 10:48:14 2013 (r249796) +++ head/sys/dev/acpi_support/acpi_toshiba.c Tue Apr 23 13:02:48 2013 (r249797) @@ -324,7 +324,7 @@ hci_force_fan(ACPI_HANDLE h, int op, UIN ACPI_SERIAL_ASSERT(toshiba); if (op == HCI_SET) { - if (*state < 0 || *state > 1) + if (*state > 1) return (EINVAL); *state <<= HCI_FAN_SHIFT; } @@ -368,7 +368,7 @@ hci_lcd_brightness(ACPI_HANDLE h, int op ACPI_SERIAL_ASSERT(toshiba); if (op == HCI_SET) { - if (*brightness < 0 || *brightness > HCI_LCD_BRIGHTNESS_MAX) + if (*brightness > HCI_LCD_BRIGHTNESS_MAX) return (EINVAL); *brightness <<= HCI_LCD_BRIGHTNESS_SHIFT; } @@ -384,7 +384,7 @@ hci_lcd_backlight(ACPI_HANDLE h, int op, ACPI_SERIAL_ASSERT(toshiba); if (op == HCI_SET) { - if (*backlight < 0 || *backlight > 1) + if (*backlight > 1) return (EINVAL); } return (hci_call(h, op, HCI_REG_LCD_BACKLIGHT, backlight)); @@ -397,7 +397,7 @@ hci_cpu_speed(ACPI_HANDLE h, int op, UIN ACPI_SERIAL_ASSERT(toshiba); if (op == HCI_SET) { - if (*speed < 0 || *speed > HCI_CPU_SPEED_MAX) + if (*speed > HCI_CPU_SPEED_MAX) return (EINVAL); *speed <<= HCI_CPU_SPEED_SHIFT; }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201304231302.r3ND2mQV024854>