Date: Sat, 5 Jan 2013 09:28:42 +1300 From: Andrew Turner <andrew@fubar.geek.nz> To: Nathan Whitehorn <nwhitehorn@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, "Robert N. M. Watson" <rwatson@FreeBSD.org> Subject: Re: svn commit: r244899 - head/sys/mips/beri Message-ID: <20130105092842.15c64ac5@fubar.geek.nz> In-Reply-To: <50E70D1E.5060208@freebsd.org> References: <201212311106.qBVB6chM016661@svn.freebsd.org> <20130102081746.5435db05@fubar.geek.nz> <D89C1409-9D10-4C09-BBF8-E00CC9B6A57A@FreeBSD.org> <20130102110856.7c280fd5@fubar.geek.nz> <0E1E1A5C-BB34-4B82-828F-6FEE770A6037@FreeBSD.org> <20130103100258.2e22763f@fubar.geek.nz> <50E70D1E.5060208@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 04 Jan 2013 12:10:54 -0500 Nathan Whitehorn <nwhitehorn@freebsd.org> wrote: > On 01/02/13 16:02, Andrew Turner wrote: > > The patch looks good. From my reading of [1] the compatible value > > should be something like "mips,mips4k" as it's value is of the form > > "<manufacturer>,<model>". > > > > I have been thinking the best way of merging these almost identical > > decode functions. Linux appears to do it by providing a > > per-controller function that can translate between the interrupt > > spec and the configuration allowing them to have a generic parsing > > function that doesn't need to check if the controller is > > compatible. I would like us to have something similar as it will > > remove the duplicate function. > > > > Andrew > > > > [1] http://www.devicetree.org/Device_Tree_Usage > PowerPC does something very much like this currently in the real OF > case. Looking at the contents of /sys/dev/fdt, it seems like there is > a lot of code duplication in particular with interrupts and PCI > handling compared to the equivalent parts of /sys/dev/ofw (and a few > extra things that are actually MI like /sys/powerpc/ofw_pci*). It > would be very nice if we could make FDT follow the normal OF > codepaths instead of (partially) reinventing the wheel. > -Nathan Ok, I'll look to figure out how much of this code we can use with FDT. Andrew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130105092842.15c64ac5>