Date: Tue, 23 Jun 2020 16:59:33 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 204521] [new driver] [request] Port rtsx from OpenBSD to FreeBSD Message-ID: <bug-204521-227-uHhDxrnaw9@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-204521-227@https.bugs.freebsd.org/bugzilla/> References: <bug-204521-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D204521 --- Comment #264 from gnikl@justmail.de --- (In reply to Henri Hennebert from comment #256) (In reply to Henri Hennebert from comment #260) I can report partial success for 106fb99f7c54616c3e853d942be4c2faf81c6d0b. There was a bug with RTSX_REVERSE_SOCKET for 5227 and 522A. With that fixed= the card state is again detected successfully and I can access the card. I only tested booting into FreeBSD after power-on. -- cut -- diff --git a/rtsx.c b/rtsx.c index ae599ee..a4518e1 100644 --- a/rtsx.c +++ b/rtsx.c @@ -876,7 +876,7 @@ rtsx_init(struct rtsx_softc *sc) RTSX_WRITE(sc, RTSX_SD30_CMD_DRIVE_SEL, driving_3v3[sc->rtsx_sd30_drive_sel_3v3][1]); RTSX_WRITE(sc, RTSX_SD30_DAT_DRIVE_SEL, driving_3v3[sc->rtsx_sd30_drive_sel_3v3][2]); /* Configure force_clock_req */ - if (sc->rtsx_flags | RTSX_REVERSE_SOCKET) + if ((sc->rtsx_flags & RTSX_REVERSE_SOCKET) !=3D 0) RTSX_BITOP(sc, RTSX_PETXCFG, 0xB8, 0xB8); else RTSX_BITOP(sc, RTSX_PETXCFG, 0xB8, 0x88); @@ -903,7 +903,7 @@ rtsx_init(struct rtsx_softc *sc) RTSX_WRITE(sc, RTSX_SD30_CMD_DRIVE_SEL, driving_3v3[sc->rtsx_sd30_drive_sel_3v3][1]); RTSX_WRITE(sc, RTSX_SD30_DAT_DRIVE_SEL, driving_3v3[sc->rtsx_sd30_drive_sel_3v3][2]); /* Configure force_clock_req */ - if (sc->rtsx_flags | RTSX_REVERSE_SOCKET) + if ((sc->rtsx_flags & RTSX_REVERSE_SOCKET) !=3D 0) RTSX_BITOP(sc, RTSX_PETXCFG, 0xB8, 0xB8); else RTSX_BITOP(sc, RTSX_PETXCFG, 0xB8, 0x88); -- cut -- (In reply to Henri Hennebert from comment #259) Out of curiosity I activated the vendor code again which still fails but I suppose that is to be expected without a change in that part of the code. I forgot to get the lspci output. Are you still interested in that data? --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-204521-227-uHhDxrnaw9>