From owner-cvs-all  Sun May  9 17:44: 6 1999
Delivered-To: cvs-all@freebsd.org
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.26.10.9])
	by hub.freebsd.org (Postfix) with ESMTP
	id D265F14CA4; Sun,  9 May 1999 17:43:48 -0700 (PDT)
	(envelope-from bde@godzilla.zeta.org.au)
Received: (from bde@localhost)
	by godzilla.zeta.org.au (8.8.7/8.8.7) id KAA08334;
	Mon, 10 May 1999 10:43:44 +1000
Date: Mon, 10 May 1999 10:43:44 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199905100043.KAA08334@godzilla.zeta.org.au>
To: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org,
	nsayer@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_time.c
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

>  Modified files:        (Branch: RELENG_3)
>    sys/kern             kern_time.c 
>  Log:
>  MFC: securelevel time setting handling code. This has worked
>  perfectly on a number of RELENG_3 machines since it was added
>  to -current.

This should be backed out of both -current and RELENG_3.  Only the part
that disallows setting the clock forward is correct.  Bugs in the other
parts include:

- success is returned after clamping the time to a time other than the
  one requested.
- error messages about clamping are printed at splhigh().

An application can only avoid these problems by being fairly aware of
the implementation and doing micro-adjustments, but micro-adjustments
can be done better using adjtime(2), modulo the reluctance of adjtime()
to adjust the time rapidly.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message