From nobody Sun Feb 15 13:56:11 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fDS9l69Grz6RX0Y for ; Sun, 15 Feb 2026 13:56:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fDS9l3Kf2z3TBv for ; Sun, 15 Feb 2026 13:56:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771163771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TPDNg3aVAEXhT4MJCkF3RdXkXeR8Q1SkTzVsqiiN/Fk=; b=UKnfYvqUdxVHsZK16mefd1xQB2PHyc5cGYF0V0mdubPa58UqP+1KCAcS4YT27toXVB7FLm kjmHGZESoi8SXm7Tl4W6P3y68cjTy5OFA0KNcFAxMYMTH4VpicJiTQNvjx7NhEVxw0xMpm TWRQV0eo4BRBS6+fp21gUeChJr4psr6m+RPKRhT9sftFG5JoXxOEog8fa9XUFzkc7pWrgL YyHyybypj11iGb7VmE/B580bd21dkoqtiKnaLTOC2fbdtFYY98UMoOSaMGcX8Fp5liJBAo O6lqm9CJGbGf9w/39SEy/zjRc9bjaW/Oeq6Ad6rk0FrVyNBYtOHPucZX4zLSng== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771163771; a=rsa-sha256; cv=none; b=W47yLX6h2uviCTDfQGitiAdnzZh0GdemUtSYWJXfGhM4aT2t7YZNBLjwuppncg4I6wN05/ yyZkFVClDIaCKqMkCW3Ww7oxcZezuJbkO3Zfx+G77q14F1BUIefvkqA7I5faraJ/F/ur5+ EPdELlmptYJ2N6TJ8dO+yh7/AA+C6rM4omu2AFLXB/LHeZaxp2qROJu49oWH2mUL0fhHoi ebyiPkyZQowi5LCbQso34JB4mZyYBtfH1F6fIBxRYvIDXdU3qn6itFWZrxR1YKq2nQNdM/ DId1jUCMfGhu5VI5GpKBJQo2hEUIucwCrBzL77NMvwh10yuJ2xFNKPP9fYLQ1g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771163771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TPDNg3aVAEXhT4MJCkF3RdXkXeR8Q1SkTzVsqiiN/Fk=; b=HltQnxYMNQO9SszjgZk4V3FH4Z/wsMvSgSdgKS67vGWxO2qptgheLNpCj9xA3FZ6G7oYPR kXYfMwi8tV9v4C2sfjjGxrVNi+mXQ5iy/Hx9C6Krgy+UPTvS5S9TiKKl+pVPDBPQhb3XwH o0AfDVg11lBQbakzauYJ4WQBSHJUGVitwZX03j+a3Wd1yfLGFHzyfKzqC42wvdTridVh1Z Ab2WQ0z9VcgxHHKxT4hpMg7JYXBxz3wLapLbcm5QV4QdvFtfN9RkrhnTNxquzDs+s3aV6G XTQWHpi3BdFBSDt9in7eZJkWAxijpUObpkZhQwIC/WyjSDWyX2Pro4hCwm0otg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fDS9l2dDSzwJ9 for ; Sun, 15 Feb 2026 13:56:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 43f21 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 15 Feb 2026 13:56:11 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ahmad Khalifa Subject: git: a60e7e6ff0ec - main - stand: compile ia32 EFI loader with -malign-double List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a60e7e6ff0ec1fdd66c2568ac6c03b843dbb3c9d Auto-Submitted: auto-generated Date: Sun, 15 Feb 2026 13:56:11 +0000 Message-Id: <6991d07b.43f21.696cde4f@gitrepo.freebsd.org> The branch main has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=a60e7e6ff0ec1fdd66c2568ac6c03b843dbb3c9d commit a60e7e6ff0ec1fdd66c2568ac6c03b843dbb3c9d Author: Ahmad Khalifa AuthorDate: 2026-02-15 12:23:26 +0000 Commit: Ahmad Khalifa CommitDate: 2026-02-15 13:30:06 +0000 stand: compile ia32 EFI loader with -malign-double The UEFI spec says: > Structures are aligned on boundaries equal to the largest internal > datum of the structure and internal data are implicitly padded to > achieve natural alignment. By default, structs containing members of type "long long" have 4 byte alignment on i386. This caused some EFI structures to be subtly wrong. Fix this by compiling the ia32 EFI loader with -malign-double, which bumps the alignment up to 8 if such members are present. MFC after: 3 days --- stand/efi/loader/arch/i386/Makefile.inc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/stand/efi/loader/arch/i386/Makefile.inc b/stand/efi/loader/arch/i386/Makefile.inc index e27b553c6bab..89fcb2a3c093 100644 --- a/stand/efi/loader/arch/i386/Makefile.inc +++ b/stand/efi/loader/arch/i386/Makefile.inc @@ -7,3 +7,5 @@ SRCS+= amd64_tramp.S \ SRCS+= nullconsole.c \ comconsole.c \ spinconsole.c + +CFLAGS+= -malign-double